Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix macOS man page symlinks #2093

Merged
merged 1 commit into from
Sep 22, 2020
Merged

fix macOS man page symlinks #2093

merged 1 commit into from
Sep 22, 2020

Conversation

glvnst
Copy link
Contributor

@glvnst glvnst commented Aug 14, 2020

Fixes #2092 and does some housekeeping... probably more than you want (I'm happy to pare this down).

  • tabs changed to spaces for safer copy/paste
  • add comment labels to steps
  • DRY-out lib copy and config file install (one-shot for-loop giving cleaner control flow)
  • change mv to cp during config config file install to enable simpler UNIXier mod check in future (diff opensc.conf{,.orig})
  • remove refs to man pages during symlink step
  • carefully remove the glob character symlinks described in macOS package postinstall script writes shell glob character symlinks to /usr/local #2092
  • shellcheck-recommended quoting
Checklist

No items apply

* add comment labels to steps
* DRY-out lib copy and config file install (one-shot for-loop giving cleaner control flow)
* change mv to cp during config config file install to enable simpler UNIXier mod check in future (diff opensc.conf{,.orig})
* remove refs to man pages during symlink step
* carefully remove the glob character symlinks described in OpenSC#2092
* shellcheck-recommended quoting
Copy link
Member

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution. Looks good from bash point of view. Can not comment on OSX specifics.

@frankmorgner frankmorgner merged commit 16a0aea into OpenSC:master Sep 22, 2020
@frankmorgner
Copy link
Member

what fun it is to write programs in shell scripts 😉 thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS package postinstall script writes shell glob character symlinks to /usr/local
3 participants