Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: OpenSC/OpenSC Loading
base: master
Choose a base ref
...
head repository: OpenSC/OpenSC Loading
compare: multi-apps
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 16 commits
  • 161 files changed
  • 6 contributors

Commits on Jan 22, 2024

  1. Configuration menu
    Copy the full SHA
    2641c8c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d8ddde5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    46a36bc View commit details
    Browse the repository at this point in the history
  4. Avoid implicit casts from 64b int types

    These are exposed by a shorten-64-to-32 warning from clang that is turned
    out automatically when building release build for OSX.
    
    They can be also triggered manually with similar configuration like this:
    
        CC=clang CFLAGS=-Wshorten-64-to-32 ./configure && make -j8
    
    Should fix #2967
    Jakuje committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    c115ab4 View commit details
    Browse the repository at this point in the history
  5. Add missing config.h to build failure with strict checking

    Without the config, clang complains about conflicting types
    
    reader-tr03119.c:138:5: error: conflicting types for 'escape_pace_input_to_buf'
    int escape_pace_input_to_buf(sc_context_t *ctx,
        ^
    ./reader-tr03119.h:87:5: note: previous declaration is here
    int escape_pace_input_to_buf(sc_context_t *ctx,
        ^
    Jakuje committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    21e07db View commit details
    Browse the repository at this point in the history
  6. ci: Separate strict CI run

    Jakuje committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    08a9d0e View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. pkcs11-spy.c check return code

    The po->C_GetInterface is passed the callers ppInterface where
    *ppInterface may not be valid.
    
    if the po->C_GetInterface may not update the *ppInterface and return
    an error. In this case  spy_interface_function_list should not be called,
    as it assumes the *ppInterface has been modified.
    
    Found debugging FireFox version 121 where FireFox passes a ppInterface
    where *ppInterface is not a valid pointer, causing a segfault in
    spy_interface_function_list.
    
    FireFox calls C_GetInterface twice with flags = CKF_INTERFACE_FORK_SAFE
    twice then on third time requests with flag = 0  where po->GetInterface
    can support and it updates the *ppInterface  with valid data.
    
    See #2987
    
     On branch pkcs11-spy-segfault
     Changes to be committed:
    	modified:   pkcs11-spy.c
    dengert authored and frankmorgner committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    ac10c06 View commit details
    Browse the repository at this point in the history
  2. meta: add clang-format formatting configuration

    This allows for voluntary formatting with clang-format (or
    IDE tools like clang-format plugin for VS Code).
    
    Once a suitable formatting configuration is found, automatic formatting
    can be configured
    
    Tweaked by Jakub Jelen
    martinpaljak authored and frankmorgner committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    06e9bba View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    63eae6b View commit details
    Browse the repository at this point in the history
  4. Add known revisions to ignore for git blame

    Usage:
    
    git config blame.ignoreRevsFile .ignoreRevsFile
    Jakuje authored and frankmorgner committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    59c2da6 View commit details
    Browse the repository at this point in the history
  5. Add github actions for clang format

    Jakuje authored and frankmorgner committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    733d897 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    79d2f6e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4855c5f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8740b31 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2315bfa View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    dc784fb View commit details
    Browse the repository at this point in the history
Loading