Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF: API changes for future curl wake implementation, WD restructuring (Cq, OMP, skew filt) #1304

Merged
merged 5 commits into from
Oct 28, 2022

Conversation

ebranlard
Copy link
Contributor

@ebranlard ebranlard commented Oct 28, 2022

This pull request is ready to be merged

Feature or improvement description

  • Introduces API changes for future curl wake implementation in FAST.Farm: (New variables in input files, in particular Mod_Wake, and the Curled Wake inputs, which are unused variables for now)
  • Documentation of API changes
  • Update of r-test to reflect API changes
  • Restructuring of WakeDynamics:
    - Split for loops in Update states (eddy viscosity, velocity update, discrete states updates)
    - Cq and tangential velocity for future swirl implementation
    - Filtering of azimuth and skew angles
    - OpenMP parallelization of WD_CalcOutput

Impacted areas of the software
FAST.Farm

Test results, if applicable
Tests are unchanged.

NOTE: these changes were reviewed by @jjonkman several months ago, prior to the implementation of the curled wake, as part of #774 and an old branch f/ff-split

@ebranlard ebranlard self-assigned this Oct 28, 2022
@ebranlard ebranlard added this to the v3.4.0 milestone Oct 28, 2022
@ebranlard ebranlard merged commit 777a2c4 into OpenFAST:dev Oct 28, 2022
@ebranlard ebranlard deleted the f/ff-curl-api branch November 1, 2022 19:57
@andrew-platt andrew-platt mentioned this pull request Dec 19, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant