Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client-side conversion #1303

Open
huss opened this issue Jul 10, 2024 · 0 comments
Open

client-side conversion #1303

huss opened this issue Jul 10, 2024 · 0 comments

Comments

@huss
Copy link
Member

huss commented Jul 10, 2024

Is your feature request related to a problem? Please describe.

Issue #901 now has Cik in Redux state. Per the design doc on this, it is now possible to do unit conversions on the client-side.

Describe the solution you'd like

The original idea was to make this change to client-side conversions to make it faster but it does make the code more complex and there may be unforeseen issues. Issue #896 proposed to do conversions that vary with time. If this is done, doing client-side conversions will not be easy/possible and this wold be dropped.

Describe alternatives you've considered

Leave as is since works and is reasonably fast.

Additional context

This is on hold until issue #896 is resolved. If successful then this issue should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant