-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client-side conversion #1303
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Issue #901 now has Cik in Redux state. Per the design doc on this, it is now possible to do unit conversions on the client-side.
Describe the solution you'd like
The original idea was to make this change to client-side conversions to make it faster but it does make the code more complex and there may be unforeseen issues. Issue #896 proposed to do conversions that vary with time. If this is done, doing client-side conversions will not be easy/possible and this wold be dropped.
Describe alternatives you've considered
Leave as is since works and is reasonably fast.
Additional context
This is on hold until issue #896 is resolved. If successful then this issue should be closed.
The text was updated successfully, but these errors were encountered: