Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mavic 3M multispectral alignment issues #1768

Closed
ehallein opened this issue Jun 28, 2024 · 17 comments
Closed

Mavic 3M multispectral alignment issues #1768

ehallein opened this issue Jun 28, 2024 · 17 comments

Comments

@ehallein
Copy link
Contributor

How did you install ODM? (Docker, installer, natively, ...)?

Docker

What is the problem?

Multispectral bands are not aligned in orthophoto
image

What should be the expected behavior? If this is a feature request, please describe in detail the changes you think should be made to the code, citing files and lines where changes should be made, if possible.

aligned bands

How can we reproduce this? What steps did you do to trigger the problem? If this is an issue with processing a dataset, YOU MUST include a copy of your dataset AND task output log, uploaded on Google Drive or Dropbox (otherwise we cannot reproduce this).

console.txt
output and images https://drive.google.com/file/d/1p2bUUqzd-TxL-kPQttbjuv-PtB49WtzS/view?usp=sharing

create project in webODM (using nvidia GPU) and run using multispectral option on TIFFs

possibly related to https://www.reddit.com/r/UAVmapping/comments/1cacp09/processing_multispectral_dji_mavic_3m_data_with/
"First, locate the fields 'Relative Optical Center X' and 'Relative Optical Center Y' in the EXIF information of each band's photograph. These values represent the positional offset of each camera band relative to the NIR band camera (in pixels). By setting the compensation values (offset) for each band's photograph (excluding the NIR band) in software like ENVI, you can correctly combine the images. The specific method for setting the compensation values for each band will need to be referenced from the manual of ENVI or similar software."

@pierotofy
Copy link
Member

#1740

@ehallein
Copy link
Contributor Author

#1740

That's seems to be related to differences is the RGB vs multispectral lenses? There no RGB being used in my case, just the multispectral bands.

@smathermather
Copy link
Contributor

Thanks for opening the issue.

That's seems to be related to differences is the RGB vs multispectral lenses? There no RGB being used in my case, just the multispectral bands.

The problem is sufficiently related to be considered the same: either we choose a multispectral band to align to, as per @MarioTro's example here: https://gitlab.com/Yario/image_registration_dji_mavic_3m/-/blob/main/coregistration_mavic_3m_images_with_CV2.py?ref_type=heads or we align to the RGB per @lewispb's example here: https://gist.github.com/lewispb/6c7dd6022ba3266cfd4f1310d4d51f5f

In the second scenario, the exif data for that alignment is extant in the multispectral bands, so it wouldn't require RGB upload with the MS bands, so it should be independent of how exactly the data are processed.

@pierotofy
Copy link
Member

pierotofy commented Jun 28, 2024

This should be fixed with #1771

The problem was multifaceted:

  • A fault in how the homography matrices were computed on images larger than 1280 pixels
  • The RGB lens model being too different than the multispectral ones

Both should be addressed but some testing will be needed.

@ehallein
Copy link
Contributor Author

Excellent. Happy to help test.

@ehallein
Copy link
Contributor Author

ehallein commented Jun 30, 2024

This should be fixed with #1771

The problem was multifaceted:

  • A fault in how the homography matrices were computed on images larger than 1280 pixels
  • The RGB lens model being too different than the multispectral ones

Both should be addressed but some testing will be needed.

looks much better with now with the new code. although still a slight offset with redband compared to G,NIR and Red edge which all line up.
image
image

@pierotofy
Copy link
Member

@ehallein could you post your task processing log?

@ehallein
Copy link
Contributor Author

ehallein commented Jul 1, 2024

@pierotofy
here you go
console.txt

@pierotofy
Copy link
Member

pierotofy commented Jul 1, 2024

Thanks!

I don't think it might matters in this case, but always re-run from the dataset stage between version updates.

Mm, not sure why the red band ended up off. A link to the dataset (or better, a smaller subset) would help (the link on google no longer works?).

@ehallein
Copy link
Contributor Author

ehallein commented Jul 1, 2024

Thanks!

I don't think it might matters in this case, but always re-run from the dataset stage between version updates.

Mm, not sure why the red band ended up off. A link to the dataset (or better, a smaller subset) would help (the link on google no longer works?).

here are TIFFs https://drive.google.com/file/d/1OEulM3PKqwOrRDX9oCg54osxpzyJNoTg/view?usp=sharing
The restart was just a redo to test. I've run a few times, including both mac (m1 pro) and windows with same issue. I'm trying some other datasets now.

@ehallein
Copy link
Contributor Author

ehallein commented Jul 1, 2024

Here's image from another dataset. Still out. Only red band. But it's pretty close, so maybe it's just the error on the lens data.
image

@smathermather
Copy link
Contributor

smathermather commented Jul 1, 2024

Definitely seeing some minor misalignment issues.
image

https://crankyserver.com/map/project/350/task/ff48c492-0e67-4613-bc31-03b2367e8aa6/

@smathermather smathermather reopened this Jul 1, 2024
@ehallein
Copy link
Contributor Author

ehallein commented Jul 2, 2024

I just tested the same dataset using DJI Terra and it is worse
image

@Saijin-Naib
Copy link
Contributor

They may have all the internal docs and specs, but we have a Piero 🤣

@smathermather
Copy link
Contributor

They may have all the internal docs and specs, but we have a Piero 🤣

🤣 Indeed. It seems there's value to calculating homography even if you have specs from the factory.

@pierotofy
Copy link
Member

Can this be closed?

@ehallein
Copy link
Contributor Author

Yes seems to be well aligned on my tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants