Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a way to split into different packages with same codebase #2307

Open
ReimarBauer opened this issue Mar 27, 2024 · 2 comments · May be fixed by #2390
Open

Find a way to split into different packages with same codebase #2307

ReimarBauer opened this issue Mar 27, 2024 · 2 comments · May be fixed by #2390
Labels
discussion enhancement New feature or request
Milestone
10.0.0

Comments

@ReimarBauer
Copy link
Member

It's just important to me that we don't lose the namespace

We don't want to split the repository, because we have many mutual dependencies. Otherwise it usually becomes much smaller than you initially plan. All in all, that's a lot of overhead for the same number of developers.

Also related
conda-forge/mss-feedstock#165

On conda-forge each setup.py would need the proper entrypoints, but there it can be patched.

Originally posted by @ReimarBauer in #2294 (comment)
@ReimarBauer
Copy link
Member Author

ReimarBauer commented May 23, 2024 •
edited
Loading

mswms imports stuff from the MSUI

mslib/mswms/mswms.py", line 34, in <module>
    from mslib.utils.qt import Updater, Worker

mslib/utils/qt.py", line 36, in <module>
    from fslib.fs_filepicker import getSaveFileName, getOpenFileName, getExistingDirectory

That is only needed for the updater.

@ReimarBauer
Copy link
Member Author

ReimarBauer commented May 23, 2024 •
edited
Loading 

Traceback (most recent call last):
  File "/home/user/Miniforge/conda-bld/mss_1716454757865/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/mswms", line 7, in <module>
    from mslib.mswms.mswms import main
  File "/home/user/Miniforge/conda-bld/mss_1716454757865/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.10/site-packages/mslib/mswms/mswms.py", line 35, in <module>
    from mslib.mswms.wms import app as application
  File "/home/user/Miniforge/conda-bld/mss_1716454757865/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.10/site-packages/mslib/mswms/wms.py", line 145, in <module>
    from mslib.mswms import mss_plot_driver
  File "/home/user/Miniforge/conda-bld/mss_1716454757865/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.10/site-packages/mslib/mswms/mss_plot_driver.py", line 38, in <module>
    import mslib.utils.coordinate as coordinate
  File "/home/user/Miniforge/conda-bld/mss_1716454757865/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.10/site-packages/mslib/utils/coordinate.py", line 36, in <module>
    from mslib.utils.config import config_loader
  File "/home/user/Miniforge/conda-bld/mss_1716454757865/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.10/site-packages/mslib/utils/config.py", line 28, in <module>
    from PyQt5 import QtCore
ModuleNotFoundError: No module named 'PyQt5'

the config_loader is only MSUI

find_location should be separated

@ReimarBauer ReimarBauer linked a pull request May 24, 2024 that will close this issue
Draft
4 tasks
@ReimarBauer ReimarBauer added the enhancement New feature or request label May 26, 2024
@ReimarBauer ReimarBauer added this to the 10.0.0 milestone May 26, 2024
@ReimarBauer ReimarBauer mentioned this issue Jun 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion enhancement New feature or request
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

feat: Differentiate packages Open-MSS/MSS
1 participant
@ReimarBauer