Junk Ice Trap Onslaught Issue

[rrealmuto]

If you turn on ice trap "Onslaught" and ice trap appearance as "Junk Items Only", the randomizer will only shuffle Rupees (200) and Deku Nuts (10) onto ice trap models. Problem seems to be the difference in how junk items are replaced with ice traps in ItemPools.py, and how the junk ice trap models are determined in Fill.py

[fenhl]

I believe this is intended behavior, but not 100% certain.

[rrealmuto]

O alright. I thought it seemed odd that every freestanding/pot/crate item ended up being a gold rupee. Might be something to consider changing.

[r0bd0g]

This is because the only junk items not removed from the pool with onslaught enabled are gold rupees and deku nuts 10, and ice traps can only take the appearance of items in the pool. (I wonder what actually happens if there are no junk items in the pool?)

[rrealmuto]

If there are no junk items in the pool, it will use all of the junk models for the ice traps.

[fenhl]

To clarify, the reason I believe this is intended is that ice traps are only cloaked as items that are actually in the pool to make them more convincing. I've asked the other devs to make sure though.

[r0bd0g]

While intended, the results are pretty janky on these specific settings. Maybe it could be changed allow like one copy of a few more junk items to stay in the pool. The gold rupees outnumber the single 10 nuts item by quite a bit (it's also a bit weird that that single 10 nuts survives -- I think it might have just been missed when removing junk?), maybe it'd be better to not allow the quantity of items in the pool to affect how often an ice trap chooses that mask.