Update Develop #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrutinizer code quality checker fix
Instead of FEEDBACK_PASSWORD_WRONG, FEEDBACK_USERNAME_OR_PASSWORD_WRONG added.
Added a changePassword Page so logged in users can change their password (if they know the current password) Renamed some previous functions to make it more clear they are for the resetPassword page, not the changePassword page
Forgot to add this on the last commit (whoops) Just a link to the changePassword page on the header if a user is logged in
(Whoops) left in a line which printed out the password hash on error (I did this during writing to make sure the hash was making it to this point)
Removed _action from some function names I made that didn't need it (because they're not specifically for form submit) Also changed returning of some functions, to make sure they can show more than one error at once (e.g. username is taken and email is taken, before this would require one field to be fixed before seeing the other error) Removed a link from changePassword page (it was there for resetPassword and is no longer needed)
Replaced hidden input for username and just get username directly in the changePassword_action function
Renamed header for resetPassword
Fixed an error where the registerNewUser() function returned too early
Regenerate Session ID on password change
Turns out it logs you out if you do this, I'll let someone else figure out how to regenerate session id without logging out
… under certain situations)
… under certain situations)
merge develop branch into master branch
better feedback when login process fails
…e feature when user is found / not found
PR #689 : added password change feature
Develop update from head fork
Uptade from head fork
Check DB connection in try/catch block. Also when PDO is not constructed
properly, prevent to exposing database host, username and password in
plain text as:
PDO->__construct('mysql:host=127....', 'root', '12345678', Array)
by throwing custom error message
FIX: DB User & Password shown in clear text in error message
Better Text feed back!
Uptade from head fork
If admin suspend or delete own account will not be able to do any action.
Prevent to suspend or delete own account
Uptade from head fork
Also added separate line between comments and code, fixed opening bracket in method (move to the new line), remove white spaces
Also added separate line between comments and code, fixed opening brackets in method (moved to the new line), removed white spaces, added new line at the end of the file.
Fit to PSR-2: Coding Style
…redirect path for usage inside subfolder installations #773
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.