-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some of meter logic seems to be 'wonky'? #72
Comments
Thanks, I'll look into it. I don't have a full picture of the TS-code yet, so maybe @marcokreeft87 is able to shed som light on this too. |
It seems to work most of the time, but I have seen the same occational glitches, that goes away again after some time. |
Maybe the getdata is called too often? |
Ah that helps, lets try that :) |
I've made a PR, it already better that the previous version. But I can't get all bars to be the same width when one of the labels is bigger. Constant percentages doesnt seem to be the solution here. Display flex is responsive, but maybe too responsive.. For the small card its working perfectly now tho |
If you are able to catch this, please provide some more debug info (from javascript console). |
Hi Olen, Sorry I am a layman - what do you you need exactly from the console? Edit: from what I can see, the elements are getting the wrong colour here.
|
I am not sure if this is visible in the logs, but creating a release with some more debug logging could probably reveal it. |
Hi @Olen, |
Not sure if that helps in the analysis, but it seems that for the parameter "soil_moisture" I'm not facing that kind of issue. This could also only be a coincidence. However, I was setting different values via the developer tool and haven't ever experienced any issue in the display of the "moisture" level. |
I pushed a new test-release. Not sure it fixes this, but I hope so. It is hard to debug, as it only happens sometimes. If anyone experience this permanently - even with the latest flower-card.js, please provide some debug info and some output from the browser debugger to try to pinpoint what css attributes the different parts of the graph has. |
I just pushed a beta (5) with LOTS of debug info. |
After looking at the code, I am especially interessted in what your "max" is |
... but why?!?
Why then is line 313 resulting in "bad" and line 316 resulting in "100%"? Or is there some string-int conversion that fails here? But why only for certain measurements? |
Sorry for the betas - but now I cast all the values, so they should be ok. |
Only limited testing for me so far, but I think you might have cracked it - much appreciated. |
Great. |
I can also confirm that the latest change seems to have fixed the issue. At least I haven’t experienced it since then. Thank you again for fixing it 😊 |
End up with some strange meters, I don't think it's just browser caching:
Far-end shows as coloured, when it shouldn't - and you end up with a mix of red and green
Checked with the latest Beta5 release.
The text was updated successfully, but these errors were encountered: