Bug fixes for parcels in python3.8 #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixing flake8 error
As they are not correctly parsed anymore by AST in python3.8
CKehl
suggested changes
Mar 19, 2020
erikvansebille
added a commit
that referenced
this pull request
Sep 7, 2020
…ated As reported in #910, the ast fix for python3.8 in #753 only appeared to work when the docstring was on the top of the concatinated kernel. Now, we assume that all strings are docstrings or comments by default and can be removed. The only exception is the string 'parcels_customed_Cfunc_pointer_args', which is needed when c kernels are included (see tests/test_kernel_language.py -> test_c_kernel) This fixes #910
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #752, parcels does not currently work with python3.8. To address this, we need to implement at least the following fixes
ast.Modulecall in py3.8 (see e.g. ast.Module signature change in Python 3.8.0a3 causes TypeError pallets/werkzeug#1551)function Pool.__del__at end of parcels run