Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation missing Controls class #198

Open
jharnois4512 opened this issue Jul 22, 2022 · 3 comments
Open

Documentation missing Controls class #198

jharnois4512 opened this issue Jul 22, 2022 · 3 comments

Comments

@jharnois4512
Copy link
Contributor

Hi all,

Just noticed that there was no Controls class in the documentation under the docs folder. Not sure if you were aware of it. Just wanted to bring light to it.

@izar-sqsp
Copy link
Contributor

Thanks, good catch! Do you want to send a PR for it? It would be most welcome!

@jharnois4512
Copy link
Contributor Author

I have a PR ready. It seems like I got a 403 when I tried to write to a new branch. Do I have to be added to write - I have never contributed to on open source project so not sure if there's something more I have to do :)

@raphaelahrens
Copy link
Contributor

Hi,
from your reply is is unclear what you have done to get the 403, but I assume you tried to directly push to izars repo.
GitHubs workflow is a little bit weird in the beginning.

You first need to create a fork of izars repo, so that you have your own Github repo where you can push your change to.
Then you can add your GitHub repo as a remote to your local repo and then push your changes into your GitHub repo.
After that you can use the Github-WebUI to create a pull request from your GitHub repo to izars repo.

Here is a HowTo which describes the required steps in more detail and color.
https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants