Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmr lpdaac patch #928

Merged
merged 6 commits into from
May 23, 2024
Merged

Cmr lpdaac patch #928

merged 6 commits into from
May 23, 2024

Conversation

jgallagher59701
Copy link
Member

Patch for the CMR UMM-G record that has a RelatedURL Type GET DATA record that will break Hyrax because it references some XML file and not a data file.

Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 23, 2024

@jgallagher59701 jgallagher59701 marked this pull request as ready for review May 23, 2024 19:26
Copy link
Contributor

@ndp-opendap ndp-opendap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THis is good, but I do have concern about the CMR granule query example in the new cmr_json_responses/README file which I would like you to address.

:shipit:

modules/ngap_module/unit-tests/cmr_json_responses/README Outdated Show resolved Hide resolved
in modules/ngap_module/unit-tests/cmr_json_responses/README
@jgallagher59701 jgallagher59701 merged commit c18281d into master May 23, 2024
1 check failed
@jgallagher59701 jgallagher59701 deleted the cmr-lpdaac-patch branch May 23, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants