Ngap cache #821
Ngap cache #821
Conversation
I used the existing BESContainer attributes to signal that access() was going to return the cached content (the whole XML doc as a string) and not a file name. I extended teh DMZ parser so that it can parse strings. I added some timing to the new code along with 'hit' or 'miss' text for the 'cache' BESDebug key. It's pretty rough still.
There was a problem hiding this comment.
There is a systemic swapping of real_name in the parameters.
for example:
bool NgapContainer::get_dmrpp_cache(const string &url_key, string &real_name)
But then it's used is like:
dmrpp_cache(get_real_name(), dmrpp_string)
Which is very confusing to me, a human. I think the semantics of these caching methods would be greatly improved if they stuck to consistent generic variable naming like:
bool NgapContainer::get_dmrpp_cache(const string &key, string &value)
Or simply got the associations correct:
bool NgapContainer::get_dmrpp_cache(const string &real_name, string &dmrpp)
…around the NGAP auth I tried using a token - just as an experiment since we cannot check that into GitHub, etc., but it didn't work.I should have been able to get a bearer token set using a context to work.
The ngap.conf file explicitly sets the caches to 'true'. Also, modified the comments in the DMR++ module to indicate that the module uses local caches for the DDS and DAS (DAP2 metadata) but that the DMR++ caching in currently done in the NGAP module.
…share' using in its place For this modification, the code that managed the curl handle pool (the original code) processed data from 20 requests for 2 variables with contiguous storage in 222ms. Removing the 'handle reuse' of the pool saw that time change to 351ms. Using the sharing feature of curl (and the blunt force trauma lock functions) and that time becomes 227ms. So our self-managed and the libcurl scheme are effectively equal, with the latter having some room for better performance if the lock functions are improved. jhrg 10/6/23
No performance testing, but the unit and regressoion tests work.
…atform Also, moved the CurlHandlePool instance to a unique_ptr<>.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.