Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODR violations when modules loaded into besstandalone #933

Closed
ndp-opendap opened this issue May 28, 2024 · 0 comments · Fixed by #934
Closed

ODR violations when modules loaded into besstandalone #933

ndp-opendap opened this issue May 28, 2024 · 0 comments · Fixed by #934
Assignees

Comments

@ndp-opendap
Copy link
Contributor

ndp-opendap commented May 28, 2024

In the dmrpp_module/testsuite/bes.conf.in file both the runtime loadable modules 

  • libdmrpp_module.so
  • libbuilddmrpp_module.so

are loaded into besstandalone from the bes.conf file in the modules/dmrpp_module /testsuite directory. This causes ODR violations to be detected by ASAN. The first error encountered is the redefinition of http/HttpError.cc 

The obvious fix here is to simply eliminate the use of libbuilddmrpp_module.so from the bes.conf.in because it's not used in these tests. I removed it and ASAN was happy and all the tests behaved as expected.

But it is an outstanding question as to why this ODR violation happened given that we load lots of modules. Is this something we need to address in how we structure our build/deployment?

Inquiring minds want to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant