Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Glacier or Gdir type to store glacier state and initial conditions #93

Closed
JordiBolibar opened this issue Jan 20, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@JordiBolibar
Copy link
Member

Same as for the case of the Simulation type. We have too many basic types going around, and we need to tidy things up. Instead of passing so many matrices and scalars to the solver, we should gather everything in a type Glacier to be passed to simulations.

We have two options here:

  • Investigate if we can directly use the gdirs, and if this is technically feasible both with OrdinaryDiffEq.jl solvers and with AD in UDEs. The fact that it will be a PyObject might make things complicated.
  • Otherwise we could just create a Gdir type in Julia to translate it, or just call it Glacier. We should also make sure that types such as mutable structs or Dicts work correctly with solvers and AD. To be thought.
@JordiBolibar JordiBolibar added the enhancement New feature or request label Jan 20, 2023
@JordiBolibar
Copy link
Member Author

This could potentially be implemented with a custom type based on MeshArrays.jl: https://github.com/JuliaClimate/MeshArrays.jl

@JordiBolibar JordiBolibar self-assigned this Jan 24, 2023
@JordiBolibar
Copy link
Member Author

Closed as it's mainly followed in #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant