Clean network logging in dockerimage #429
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MehmedGIT
approved these changes
Apr 25, 2024
|
Is this superseded by OCR-D/core#1214? |
I don't think that one is a valid solution because of security concerns. |
When I thought about the issue I came up with this two (both mentioned pr's) possible solutions. I think both possibly fixes the described problem. The "problem" with this PR is, it only fixes the problem with the ocrd-all-docker-image, and not if similar things happen with other images using ocrd like ocrd-processors. |
3a03c51
to
305cb72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #426
This pr removes the possibly created (while creating the docker image) log-file and folders so that when an docker container with ocrd is created no logfiles and folders exist and thus are created with permissions of the user starting the docker container.
Alternative to OCR-D/core#1214