Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move examples to learn.openapis.org or spec.openapis.org #3854

Open
handrews opened this issue May 24, 2024 · 5 comments · May be fixed by #3913
Open

Move examples to learn.openapis.org or spec.openapis.org #3854

handrews opened this issue May 24, 2024 · 5 comments · May be fixed by #3913
Labels
examples requests for more or better examples in the specification Housekeeping Process

Comments

@handrews
Copy link
Member

Can we move the examples in this repo (that are not part of the spec) either to the learn site or to the spec site (run from gh-pages, but see #3717 for how that is likely to change).

Going through all of the open issues just now (again), it's confusing to sort out the issues on examples in the spec from the issues about the examples directory from the general examples issues that we all agree should go on the learn site. It would really help with issue curating if all of the outside-of-spec examples lived in one place.

@handrews handrews added Housekeeping Process examples requests for more or better examples in the specification review labels May 24, 2024
@handrews
Copy link
Member Author

One concern would be that published specs link to the examples. We could either treat this like past broken links - OK to fix in place because doing so preserves the original text and behavior, rather than achanging it. Or we could do something involving redirects, atlhough whether that's feasible in GitHub I do not know.

I would prefer to move all official links to a hosted site and not be dependent on GitHub because stapling our development environment to our publication channel means we can't organize development in the idea way.

@miqui
Copy link
Contributor

miqui commented May 29, 2024

@handrews if by "spec example" you mean this: https://spec.openapis.org/oas/latest.html#examples, then I would simply leave this area as is. IMHO, good to have simple example within the spec itself immediately after the concept in question (rather than having to switch to another site, location).

If you mean "non-spec" example from these: https://github.com/OAI/OpenAPI-Specification/tree/main/examples then my humble vote is to move these to the learn site.

(on a personal note, I have never used these examples, but used the examples in the spec as I was trying to learn the spec itself and then googled, searched in github, searched in POSTMAN, etc for more complicated examples of OADs.

@handrews
Copy link
Member Author

@miqui yes, your interpretation is correct - spec examples stay in the spec, but the non-spec (which you correctly identified) are the ones I'm suggesting we move. I have also added a link to the Learn site at the top of the spec on @lornajane 's suggestion:

That will make it easier for folks who, like you, look for examples in the spec, to find the examples we have elsewhere. And it's easiest if we can just send them to the Learn site instead of multiple locations.

@darrelmiller
Copy link
Member

In TDC meeting, there were no objections to moving examples over to the learn site. This will require moving the convert to json action over also.

The spec references to examples will need to be moved to point to the learn site.

@Bellangelo
Copy link
Member

PR that adds the examples in the learn.openapis.org: OAI/learn.openapis.org#102
I haven't opened a PR yet that cleans-up this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples requests for more or better examples in the specification Housekeeping Process
Projects
Status: No status
5 participants