From e070dd7eeea382f39be7ed23b511cf40faf3d196 Mon Sep 17 00:00:00 2001 From: Neil Fulwiler Date: Tue, 23 Jul 2024 13:33:04 -0400 Subject: [PATCH] --no-build needs to go after "up" (#23177) need to add --no-build after compose, tested locally with the cli --- .../dagster-test/dagster_test/fixtures/docker_compose.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/python_modules/dagster-test/dagster_test/fixtures/docker_compose.py b/python_modules/dagster-test/dagster_test/fixtures/docker_compose.py index 5480d9b81f98e..5a22849de147b 100644 --- a/python_modules/dagster-test/dagster_test/fixtures/docker_compose.py +++ b/python_modules/dagster-test/dagster_test/fixtures/docker_compose.py @@ -94,9 +94,6 @@ def docker_compose_up(docker_compose_yml, context, service, env_file, no_build: if env_file: compose_command += ["--env-file", env_file] - if no_build: - compose_command += ["--no-build"] - compose_command += [ "--file", str(docker_compose_yml), @@ -104,6 +101,9 @@ def docker_compose_up(docker_compose_yml, context, service, env_file, no_build: "--detach", ] + if no_build: + compose_command += ["--no-build"] + if service: compose_command.append(service)