Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meteor: fix error detecting glibc/musl #357883

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tennox
Copy link
Contributor

@tennox tennox commented Nov 21, 2024

I encountered this issue running meteor:

## There is an issue with `node-fibers` ##
`/nix/store/bavm7rzjbyr97bayfm7gl3xi37scc1w4-meteor-2.7.3/packages/meteor-tool/.2.7.3.1mjjp3y.wu0o++os.linux.x86_64+web.browser+web.browser.legacy+web.cordova/mt-os.linux.x86_64/dev_bundle/lib/node_modules/fibers/bin/linux-x64-83-/fibers.node` is missing.

Try running this to fix the issue: /nix/store/bavm7rzjbyr97bayfm7gl3xi37scc1w4-meteor-2.7.3/packages/meteor-tool/.2.7.3.1mjjp3y.wu0o++os.linux.x86_64+web.browser+web.browser.legacy+web.cordova/mt-os.linux.x86_64/dev_bundle/bin/node /nix/store/bavm7rzjbyr97bayfm7gl3xi37scc1w4-meteor-2.7.3/packages/meteor-tool/.2.7.3.1mjjp3y.wu0o++os.linux.x86_64+web.browser+web.browser.legacy+web.cordova/mt-os.linux.x86_64/dev_bundle/lib/node_modules/fibers/build
Error: Cannot find module '/nix/store/bavm7rzjbyr97bayfm7gl3xi37scc1w4-meteor-2.7.3/packages/meteor-tool/.2.7.3.1mjjp3y.wu0o++os.linux.x86_64+web.browser+web.browser.legacy+web.cordova/mt-os.linux.x86_64/dev_bundle/lib/node_modules/fibers/bin/linux-x64-83-/fibers'
Require stack:
- /nix/store/bavm7rzjbyr97bayfm7gl3xi37scc1w4-meteor-2.7.3/packages/meteor-tool/.2.7.3.1mjjp3y.wu0o++os.linux.x86_64+web.browser+web.browser.legacy+web.cordova/mt-os.linux.x86_64/dev_bundle/lib/node_modules/fibers/fibers.js
- /nix/store/bavm7rzjbyr97bayfm7gl3xi37scc1w4-meteor-2.7.3/packages/meteor-tool/.2.7.3.1mjjp3y.wu0o++os.linux.x86_64+web.browser+web.browser.legacy+web.cordova/mt-os.linux.x86_64/tools/tool-env/wrap-fibers.js

and saw it has a missing glibc/musl part in the path to the fibers.node binary:

fibers/bin/linux-x64-83-/fibers.node

Found that it uses detect-libc package, which doesn't seem to work well on nixos - so I decided to patch meteor's dev_bundle fibers script, adding a fallback to glibc if detection fails (this package anyways only works with glibc):

-		((process.platform === 'linux') ? '-'+ detectLibc.family : ''), 'fibers');
+		((process.platform === 'linux') ? '-'+ (detectLibc.family || 'glibc') : ''), 'fibers');

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant