Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python314: 3.14.0a1 -> 3.14.0a2 #357452

Merged
merged 1 commit into from
Nov 21, 2024
Merged

python314: 3.14.0a1 -> 3.14.0a2 #357452

merged 1 commit into from
Nov 21, 2024
+2 −2

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Nov 20, 2024 •
edited
Loading

https://docs.python.org/3.14/whatsnew/changelog.html#python-3-14-0-alpha-2

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mweinelt mweinelt added the backport release-24.11 Backport PR automatically label Nov 20, 2024
@nix-owners nix-owners bot requested a review from natsukium November 20, 2024 02:25
natsukium
natsukium approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 20, 2024
@natsukium
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 357452

x86_64-linux

✅ 6 packages built:
  • python314
  • python314.debug
  • python314FreeThreading
  • python314FreeThreading.debug
  • python314Full
  • python314Full.debug

aarch64-linux

✅ 6 packages built:
  • python314
  • python314.debug
  • python314FreeThreading
  • python314FreeThreading.debug
  • python314Full
  • python314Full.debug

x86_64-darwin

✅ 3 packages built:
  • python314
  • python314FreeThreading
  • python314Full

aarch64-darwin

✅ 3 packages built:
  • python314
  • python314FreeThreading
  • python314Full

@natsukium natsukium merged commit 80e0606 into NixOS:master Nov 21, 2024
46 of 47 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Nov 21, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium natsukium approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mweinelt @natsukium @wegank