Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-init: refactor with nixfmt-rfc-style, passthru.tests.version and removing darwin sdk #356985

Merged
merged 3 commits into from
Nov 23, 2024

Conversation

kachick
Copy link
Member

@kachick kachick commented Nov 18, 2024

Things done

> nix-build --attr pkgs.nix-init.passthru.tests     
this derivation will be built:
  /nix/store/54850gkq3dm8rmva6d14cjlw2gkw0g0d-nix-init-0.3.2-test-version.drv
this path will be fetched (6.46 MiB download, 18.98 MiB unpacked):
  /nix/store/d371fzmyvnssxkgf1r1vqg47fd8y63i0-nix-init-0.3.2
copying path '/nix/store/d371fzmyvnssxkgf1r1vqg47fd8y63i0-nix-init-0.3.2' from 'https://cache.nixos.org'...
building '/nix/store/54850gkq3dm8rmva6d14cjlw2gkw0g0d-nix-init-0.3.2-test-version.drv'...
nix-init 0.3.2
/nix/store/j6ln6ysgqv4kyliq7m40llrglp5layqg-nix-init-0.3.2-test-version
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kachick

This comment was marked as outdated.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 19, 2024
@uncenter
Copy link
Member

(You could probably amend that last commit into nix-init: remove unnecessary darwin sdk commit if you want :p)

@kachick
Copy link
Member Author

kachick commented Nov 22, 2024

Thank you for reviewing! Now rebuilding the nixpkgs-review again, I'll post the result after finish 🙏

@kachick kachick changed the title nix-init: format with nixfmt-rfc-style and add passthru.tests.version nix-init: refactor with nixfmt-rfc-style, passthru.tests.version and removing darwin sdk Nov 22, 2024
@uncenter
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356985


aarch64-darwin

✅ 1 package built:
  • nix-init

@kachick
Copy link
Member Author

kachick commented Nov 22, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356985


x86_64-linux


x86_64-darwin

✅ 1 package built:
  • nix-init

aarch64-darwin

✅ 1 package built:
  • nix-init

@kachick kachick marked this pull request as ready for review November 22, 2024 14:47
@uncenter uncenter added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 22, 2024
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 23, 2024
@ofborg ofborg bot requested a review from figsoda November 23, 2024 08:16
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Nov 23, 2024
@Aleksanaa
Copy link
Member

@ofborg build nix-init

@Aleksanaa Aleksanaa merged commit 04f0c72 into NixOS:master Nov 23, 2024
55 of 59 checks passed
@kachick
Copy link
Member Author

kachick commented Nov 23, 2024

Thanks for your reviews!

@kachick kachick deleted the chore-nix-init branch November 23, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants