-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nix-init: refactor with nixfmt-rfc-style, passthru.tests.version and removing darwin sdk #356985
Merged
+23
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
ofborg
bot
added
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux
labels
Nov 19, 2024
uncenter
reviewed
Nov 22, 2024
kachick
force-pushed
the
chore-nix-init
branch
from
November 22, 2024 13:02
676be35
to
03dc326
Compare
uncenter
reviewed
Nov 22, 2024
(You could probably amend that last commit into |
nix-init: remove outdated input Co-authored-by: uncenter <[email protected]>
kachick
force-pushed
the
chore-nix-init
branch
from
November 22, 2024 13:50
be262c5
to
ee2d6d1
Compare
Thank you for reviewing! Now rebuilding the nixpkgs-review again, I'll post the result after finish 🙏 |
kachick
changed the title
nix-init: format with nixfmt-rfc-style and add passthru.tests.version
nix-init: refactor with nixfmt-rfc-style, passthru.tests.version and removing darwin sdk
Nov 22, 2024
|
uncenter
approved these changes
Nov 22, 2024
|
uncenter
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Nov 22, 2024
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
labels
Nov 23, 2024
@ofborg build nix-init |
Thanks for your reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: darwin
Running or building packages on Darwin
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux
12.approvals: 1
This PR was reviewed and approved by one reputable person
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.