minutor: init at 2.21.0 #356699
minutor: init at 2.21.0 #356699
Conversation
8499f70
to
4ae42b3
Compare
|
|
||
| src = fetchFromGitHub { | ||
| owner = "mrkite"; | ||
| repo = finalAttrs.pname; |
There was a problem hiding this comment.
| repo = finalAttrs.pname; | |
| repo = "minutor"; |
Excessive reference to finalAttrs will increase the eval time, the pattern here is longer, and the reference here has no logical correspondence (in contrast with version)
There was a problem hiding this comment.
There's no measurable difference between having both repo and rev depend on finalAttrs and just rev. I even had a benchmark run where it was slightly faster with repo being dynamic.
There was a problem hiding this comment.
I think the more correct reason is simply that it's discouraged in the docs.
| sha256 = "0ldjnrk429ywf8cxdpjkam5k73s6fq7lvksandfn3xn7gl9np5rk"; | ||
| }; | ||
|
|
||
| preConfigure = '' |
There was a problem hiding this comment.
| preConfigure = '' | |
| postPatch = '' |
There was a problem hiding this comment.
Logically belongs into configurePhase since we set the installation location here (as the application lacks any sort of configure script, sadly). Having stuff that depends on $out in patchPhase doesn't make sense, e.g. just think about srcOnly which would then reference the store path of the resulting patched source.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.