plausible: 2.0.0 -> 2.1.4 #356221
Open
plausible: 2.0.0 -> 2.1.4 #356221
+115
−164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c130667
to
53a87e0
Compare
blitz
reviewed
Nov 15, 2024
Comment on lines
+140
to
+143
| (mkRemovedOptionModule [ "services" "plausible" "adminUser" "name" ] "Admin user is now created using first start wizard") | ||
| (mkRemovedOptionModule [ "services" "plausible" "adminUser" "email" ] "Admin user is now created using first start wizard") | ||
| (mkRemovedOptionModule [ "services" "plausible" "adminUser" "passwordFile" ] "Admin user is now created using first start wizard") | ||
| (mkRemovedOptionModule [ "services" "plausible" "adminUser" "activate" ] "Admin user is now created using first start wizard") |
There was a problem hiding this comment.
Thanks for the actionable error messages here!
53a87e0
to
d74a185
Compare
|
Result of 1 package blacklisted:
1 package built:
|
d74a185
to
e8c9fa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: https://github.com/plausible/analytics/blob/v2.1.4/CHANGELOG.md
This upgrade was quite the undertaking, the major source of headaches was that plausible now has a dependency that makes use of rustler, tooling to call rust from elixir.
As the newer plausible version drop support for admin user reaction via env var in favour of a first install wizard, this can be backported to stable. This first install wizard is also the reason why the nixos test was reduces, as this new installed is based on phoenix live views, we can simply interact with it using
curlandgrep:/I'm yet to deploy this onto a production installation of plausible, but looking at the web UI in a simple test installation everything look fine.
Closes: #314768
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.