Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wget: 1.24.5 -> 1.25.0 #355837

Merged
merged 3 commits into from
Nov 18, 2024
Merged

wget: 1.24.5 -> 1.25.0 #355837

merged 3 commits into from
Nov 18, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Nov 14, 2024 •
edited
Loading

Changes: https://lists.gnu.org/archive/html/info-gnu/2024-11/msg00000.html

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@trofi
wget: use nuke-refs to avoid runtime depeneds
0d59db6 
That way we still preserve the compilation flags but don't retain
development headers in final closure.
@ofborg ofborg bot requested a review from fpletz November 14, 2024 18:09
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 14, 2024
@uninsane uninsane merged commit fbd0c0d into NixOS:master Nov 18, 2024
30 of 31 checks passed
@trofi trofi deleted the wget-update branch November 18, 2024 21:09
@Scrumplex Scrumplex added 1.severity: security Issues which raise a security issue, or PRs that fix one backport staging-24.05 Backport PR automatically backport staging-24.11 Backport PR automatically labels Nov 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Backport failed for staging-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin staging-24.05
git worktree add -d .worktree/backport-355837-to-staging-24.05 origin/staging-24.05
cd .worktree/backport-355837-to-staging-24.05
git switch --create backport-355837-to-staging-24.05
git cherry-pick -x 1830f82831dd49ddfe3b323e60fe98cb90d00b7c a9b6686b4faa0a0b79b408bcaa67232344abab8b 0d59db6c85d9a142aacbe16816ecc611f7e41a14

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

Backport failed for staging-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin staging-24.05
git worktree add -d .worktree/backport-355837-to-staging-24.05 origin/staging-24.05
cd .worktree/backport-355837-to-staging-24.05
git switch --create backport-355837-to-staging-24.05
git cherry-pick -x 1830f82831dd49ddfe3b323e60fe98cb90d00b7c a9b6686b4faa0a0b79b408bcaa67232344abab8b 0d59db6c85d9a142aacbe16816ecc611f7e41a14

@github-actions GitHub Actions
Copy link
Contributor

Backport failed for staging-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin staging-24.05
git worktree add -d .worktree/backport-355837-to-staging-24.05 origin/staging-24.05
cd .worktree/backport-355837-to-staging-24.05
git switch --create backport-355837-to-staging-24.05
git cherry-pick -x 1830f82831dd49ddfe3b323e60fe98cb90d00b7c a9b6686b4faa0a0b79b408bcaa67232344abab8b 0d59db6c85d9a142aacbe16816ecc611f7e41a14

@github-actions GitHub Actions
Copy link
Contributor

Git push to origin failed for staging-24.11 with exitcode 1

@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Closed
1 task
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for staging-24.11:

@github-actions GitHub Actions
Copy link
Contributor

Git push to origin failed for staging-24.11 with exitcode 1

@SuperSandro2000 SuperSandro2000 added backport release-24.05 Backport PR automatically backport release-24.11 Backport PR automatically and removed backport staging-24.05 Backport PR automatically backport staging-24.11 Backport PR automatically labels Nov 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-355837-to-release-24.05 origin/release-24.05
cd .worktree/backport-355837-to-release-24.05
git switch --create backport-355837-to-release-24.05
git cherry-pick -x 1830f82831dd49ddfe3b323e60fe98cb90d00b7c a9b6686b4faa0a0b79b408bcaa67232344abab8b 0d59db6c85d9a142aacbe16816ecc611f7e41a14

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-355837-to-release-24.05 origin/release-24.05
cd .worktree/backport-355837-to-release-24.05
git switch --create backport-355837-to-release-24.05
git cherry-pick -x 1830f82831dd49ddfe3b323e60fe98cb90d00b7c a9b6686b4faa0a0b79b408bcaa67232344abab8b 0d59db6c85d9a142aacbe16816ecc611f7e41a14

@github-actions GitHub Actions
Copy link
Contributor

Git push to origin failed for release-24.11 with exitcode 1

@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.05 Backport PR automatically backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@trofi @drupol @SuperSandro2000 @wegank @Scrumplex @uninsane