Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtualbox: 7.0.22 -> 7.1.4 (Qt6 support) #353857

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Virtualbox: 7.0.22 -> 7.1.4 (Qt6 support) #353857

wants to merge 1 commit into from
+59 −94

Conversation

Mrmaxmeier
Copy link
Contributor

Hi,
in an effort to debug an issue with VirtualBox, I've tried updating to the recent Qt6-based 7.1 release.
While it didn't fix my issue the non-trivial update might still be helpful to somebody 🙃

The Qt dependency paths patch seems like a quite unfortunate hack to me, but I didn't see a way to avoid it. In general, keep in mind that I don't know what I'm doing here while reviewing 🙂

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
    • virtualbox-kvm is currently broken in the main branch but this update widens the gap between the existing patch set and the virtualbox version
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Mrmaxmeier Mrmaxmeier force-pushed the virtualbox-update-7.1-qt6 branch 2 times, most recently from e368620 to d74f1ec Compare November 5, 2024 20:46
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Nov 6, 2024
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Nov 6, 2024
@FriedrichAltheide
Copy link
Contributor

4 packages marked as broken and skipped:
  • linuxKernel.packages.linux_5_4_hardened.virtualbox
  • linuxKernel.packages.linux_5_4_hardened.virtualboxGuestAdditions
  • linuxPackages_5_4_hardened.virtualbox
  • linuxPackages_5_4_hardened.virtualboxGuestAdditions
1 package failed to build:
  • virtualboxKvm
41 packages built:
  • linuxKernel.packages.linux_5_10.virtualbox
  • linuxKernel.packages.linux_5_10.virtualboxGuestAdditions
  • linuxPackages_5_10_hardened.virtualbox (linuxKernel.packages.linux_5_10_hardened.virtualbox)
  • linuxPackages_5_10_hardened.virtualboxGuestAdditions (linuxKernel.packages.linux_5_10_hardened.virtualboxGuestAdditions)
  • linuxKernel.packages.linux_5_15.virtualbox
  • linuxKernel.packages.linux_5_15.virtualboxGuestAdditions
  • linuxPackages_5_15_hardened.virtualbox (linuxKernel.packages.linux_5_15_hardened.virtualbox)
  • linuxPackages_5_15_hardened.virtualboxGuestAdditions (linuxKernel.packages.linux_5_15_hardened.virtualboxGuestAdditions)
  • linuxKernel.packages.linux_5_4.virtualbox
  • linuxKernel.packages.linux_5_4.virtualboxGuestAdditions
  • linuxKernel.packages.linux_6_1.virtualbox
  • linuxKernel.packages.linux_6_1.virtualboxGuestAdditions
  • linuxPackages_latest.virtualbox (linuxKernel.packages.linux_6_11.virtualbox)
  • linuxPackages_latest.virtualboxGuestAdditions (linuxKernel.packages.linux_6_11.virtualboxGuestAdditions)
  • linuxPackages_6_1_hardened.virtualbox (linuxKernel.packages.linux_6_1_hardened.virtualbox)
  • linuxPackages_6_1_hardened.virtualboxGuestAdditions (linuxKernel.packages.linux_6_1_hardened.virtualboxGuestAdditions)
  • linuxPackages.virtualbox (linuxKernel.packages.linux_6_6.virtualbox)
  • linuxPackages.virtualboxGuestAdditions (linuxKernel.packages.linux_6_6.virtualboxGuestAdditions)
  • linuxPackages_hardened.virtualbox (linuxPackages_6_6_hardened.virtualbox)
  • linuxPackages_hardened.virtualboxGuestAdditions (linuxPackages_6_6_hardened.virtualboxGuestAdditions)
  • linuxPackages_latest-libre.virtualbox (linuxKernel.packages.linux_latest_libre.virtualbox)
  • linuxPackages_latest-libre.virtualboxGuestAdditions (linuxKernel.packages.linux_latest_libre.virtualboxGuestAdditions)
  • linuxPackages-libre.virtualbox (linuxKernel.packages.linux_libre.virtualbox)
  • linuxPackages-libre.virtualboxGuestAdditions (linuxKernel.packages.linux_libre.virtualboxGuestAdditions)
  • linuxPackages_lqx.virtualbox (linuxKernel.packages.linux_lqx.virtualbox)
  • linuxPackages_lqx.virtualboxGuestAdditions (linuxKernel.packages.linux_lqx.virtualboxGuestAdditions)
  • linuxPackages_xanmod.virtualbox (linuxKernel.packages.linux_xanmod.virtualbox)
  • linuxPackages_xanmod.virtualboxGuestAdditions (linuxKernel.packages.linux_xanmod.virtualboxGuestAdditions)
  • linuxPackages_xanmod_latest.virtualbox (linuxKernel.packages.linux_xanmod_latest.virtualbox ,linuxPackages_xanmod_stable.virtualbox)
  • linuxPackages_xanmod_latest.virtualboxGuestAdditions (linuxKernel.packages.linux_xanmod_latest.virtualboxGuestAdditions ,linuxPackages_xanmod_stable.virtualboxGuestAdditions)
  • linuxPackages_zen.virtualbox (linuxKernel.packages.linux_zen.virtualbox)
  • linuxPackages_zen.virtualboxGuestAdditions (linuxKernel.packages.linux_zen.virtualboxGuestAdditions)
  • virtualbox
  • virtualbox.modsrc
  • virtualboxExtpack
  • virtualboxHardened
  • virtualboxHardened.modsrc
  • virtualboxHeadless
  • virtualboxHeadless.modsrc
  • virtualboxWithExtpack
  • virtualboxWithExtpack.modsrc

@FriedrichAltheide FriedrichAltheide added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 7, 2024
@SuperSandro2000
Copy link
Member

@blitz fyi

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/install-virtualbox-7-1/56265/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriedrichAltheide FriedrichAltheide FriedrichAltheide approved these changes

@blitz blitz Awaiting requested review from blitz

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mrmaxmeier @FriedrichAltheide @SuperSandro2000 @nixos-discourse