Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildGoPackage: remove #349478

Merged
merged 3 commits into from
Nov 19, 2024
Merged

buildGoPackage: remove #349478

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ad1097
buildGoPackage: remove
katexochen Oct 18, 2024
2ac1f68
docs: update Go section after buildGoPackage removal
katexochen Oct 18, 2024
41d7136
buildGoModule: remove goPackagePath warning
katexochen Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
buildGoPackage: remove 
Signed-off-by: Paul Meyer <[email protected]>
  • Loading branch information
@katexochen
katexochen committed Nov 18, 2024
commit 4ad10975ec3fcf8bf0060d8700f122fe0de7aef5
2 changes: 2 additions & 0 deletions nixos/doc/manual/release-notes/rl-2505.section.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@

<!-- To avoid merge conflicts, consider adding your item at an arbitrary place in the list instead. -->

- `buildGoPackage` has been removed. Use `buildGoModule` instead. See the Go section in the nixpkgs manual for details.
katexochen marked this conversation as resolved.
Show resolved Hide resolved

- `kanata` was updated to v1.7.0, which introduces several breaking changes.
See the release notes of
[v1.7.0](https://github.com/jtroo/kanata/releases/tag/v1.7.0)
Expand Down
295 changes: 0 additions & 295 deletions pkgs/build-support/go/package.nix
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions pkgs/top-level/aliases.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ mapAliases {

budgie = throw "The `budgie` scope has been removed and all packages moved to the top-level"; # Added 2024-07-14
budgiePlugins = throw "The `budgiePlugins` scope has been removed and all packages moved to the top-level"; # Added 2024-07-14
buildGoPackage = throw "`buildGoPackage` has been deprecated and removed, see the Go section in the nixpkgs manual for details"; # Added 2024-11-18

inherit (libsForQt5.mauiPackages) buho; # added 2022-05-17
butler = throw "butler was removed because it was broken and abandoned upstream"; # added 2024-06-18
Expand Down
7 changes: 0 additions & 7 deletions pkgs/top-level/all-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11424,23 +11424,16 @@ with pkgs;
# the unversioned attributes should always point to the same go version
go = go_1_23;
buildGoModule = buildGo123Module;
buildGoPackage = buildGo123Package;

go_1_22 = callPackage ../development/compilers/go/1.22.nix { };
buildGo122Module = callPackage ../build-support/go/module.nix {
go = buildPackages.go_1_22;
};
buildGo122Package = callPackage ../build-support/go/package.nix {
go = buildPackages.go_1_22;
};

go_1_23 = callPackage ../development/compilers/go/1.23.nix { };
buildGo123Module = callPackage ../build-support/go/module.nix {
go = buildPackages.go_1_23;
};
buildGo123Package = callPackage ../build-support/go/package.nix {
go = buildPackages.go_1_23;
};

### DEVELOPMENT / HARE

Expand Down