Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildGoPackage: remove #349478

Merged
merged 3 commits into from
Nov 19, 2024
Merged

buildGoPackage: remove #349478

merged 3 commits into from
Nov 19, 2024

Conversation

katexochen
Copy link
Contributor

@katexochen katexochen commented Oct 18, 2024 •
edited
Loading

Closes #318069

I reordered most of the subsection in the Go docs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@katexochen katexochen mentioned this pull request Oct 18, 2024
Closed
35 tasks
@katexochen
Copy link
Contributor Author

katexochen commented Oct 18, 2024 •
edited
Loading

Waiting for 24.11 branch-off (but can already be reviewed 😉)

@emilazy emilazy added the 2.status: wait for branch‐off Waiting for the next Nixpkgs branch‐off label Oct 18, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 18, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Nov 15, 2024
@katexochen katexochen marked this pull request as ready for review November 15, 2024 08:22
@katexochen katexochen removed the 2.status: wait for branch‐off Waiting for the next Nixpkgs branch‐off label Nov 15, 2024
@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Nov 15, 2024
Aleksanaa
Aleksanaa reviewed Nov 16, 2024
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Add throw in pkgs/top-level/aliases.nix
  2. Add a release note in nixos/doc/manual/release-notes/rl-2505.section.md

@katexochen katexochen mentioned this pull request Nov 17, 2024
Merged
13 tasks
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog labels Nov 18, 2024
@nix-owners nix-owners bot requested a review from hsjobeki November 18, 2024 06:49
@katexochen
buildGoPackage: remove
4ad1097 
Signed-off-by: Paul Meyer <[email protected]>
GetPsyched
GetPsyched suggested changes Nov 18, 2024
View reviewed changes
Copy link
Member

@GetPsyched GetPsyched left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to account for these removed entries so that anyone heading to the old link is redirected to the new ones (or to a link hinting at why it was removed -- like release notes or some section with a callout)

doc/redirects.json Outdated Show resolved Hide resolved
doc/redirects.json Outdated Show resolved Hide resolved
doc/redirects.json Show resolved Hide resolved
GetPsyched
GetPsyched reviewed Nov 18, 2024
View reviewed changes
doc/redirects.json Outdated Show resolved Hide resolved
GetPsyched
GetPsyched reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@GetPsyched GetPsyched left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redirects lgtm

hsjobeki
hsjobeki reviewed Nov 18, 2024
View reviewed changes
doc/redirects.json
],
"ex-buildGoModule": [
"index.html#ex-buildGoModule"
],
"buildGoModule-vendorHash": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldnt this redirect to the new urls?

Copy link
Contributor Author

@katexochen katexochen Nov 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does: https://github.com/NixOS/nixpkgs/pull/349478/files#diff-9499ad98fd024845445ff2f32b424d29f632932b4bbe15dfd9d0f447890bbae6R2764

Copy link
Member

@GetPsyched GetPsyched Nov 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's hard to see because the identifier moved to a different line. This should be solved when the helper command is made.

EDIT: #357383

@katexochen
docs: update Go section after buildGoPackage removal
2ac1f68 
Signed-off-by: Paul Meyer <[email protected]>
@katexochen
buildGoModule: remove goPackagePath warning
41d7136 
As buildGoPackage was removed, it is unlikely for attributes of
buildGoModule to get mixed up with those of buildGoPackage.

Signed-off-by: Paul Meyer <[email protected]>
@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Nov 19, 2024
@katexochen
Copy link
Contributor Author

can someone merge/ give their final approval?

@Aleksanaa Aleksanaa merged commit 0ecc88f into NixOS:master Nov 19, 2024
26 checks passed
@katexochen katexochen deleted the buildGoPackage/remove branch November 19, 2024 14:46
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/splitting-the-nixpkgs-and-nixos-manuals-into-pages/55466/9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsjobeki hsjobeki hsjobeki left review comments

@GetPsyched GetPsyched GetPsyched requested changes

@zowoq zowoq zowoq approved these changes

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@kirillrdy kirillrdy kirillrdy approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@Mic92 Mic92 Awaiting requested review from Mic92

@fricklerhandwerk fricklerhandwerk Awaiting requested review from fricklerhandwerk

Assignees
No one assigned
Labels
6.topic: golang 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
Go team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation of buildGoPackage
10 participants
@katexochen @nixos-discourse @kirillrdy @fricklerhandwerk @Aleksanaa @GetPsyched @hsjobeki @zowoq @wegank @emilazy