Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixVersions.git: Fix version and test it #323140

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

roberth
Copy link
Member

@roberth roberth commented Jun 28, 2024

Description of changes

  • Fix version
  • test it

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@roberth
Copy link
Member Author

roberth commented Jun 28, 2024

@ofborg build nix
@ofborg build nixVersions.nix_2_18
@ofborg build nixVersions.nix_2_19
@ofborg build nixVersions.nix_2_20
@ofborg build nixVersions.nix_2_21
@ofborg build nixVersions.nix_2_22
@ofborg build nixVersions.nix_2_23
@ofborg build nixVersions.git

@Artturin Artturin merged commit 4e8d08a into NixOS:master Jul 2, 2024
60 checks passed
@Artturin Artturin added the backport release-24.05 Backport PR automatically label Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-323140-to-release-24.05 origin/release-24.05
cd .worktree/backport-323140-to-release-24.05
git switch --create backport-323140-to-release-24.05
git cherry-pick -x 5660f47241d250b7c0bfa7759df6abca93148208 42877a5b2cb5867b5ae3c691add25c05cc69dccb

@Artturin
Copy link
Member

Artturin commented Jul 3, 2024

backport #324408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants