Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.05] python3Packages.clustershell: remove blocking test #321050

Merged
merged 1 commit into from
Jun 19, 2024
Merged

[Backport release-24.05] python3Packages.clustershell: remove blocking test #321050

merged 1 commit into from
Jun 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 19, 2024 •
edited by bjornfor
Loading

Bot-based backport to release-24.05, triggered by a label in #317135.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@woffs @github-actions
python3Packages.clustershell: remove blocking test
fdf2b2a 
remove tests/TreeGatewayTest.py because it does not return.

apparently

    def wait(self):
        """wait for task/thread termination"""
        # can be blocked indefinitely if StreamWorker doesn't complete
        self.task.join()

does apply in nix sandbox

fixes #315146

(cherry picked from commit 53d22e3)
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Merged
13 tasks
@bjornfor bjornfor merged commit efddd15 into release-24.05 Jun 19, 2024
2 checks passed
@bjornfor bjornfor deleted the backport-317135-to-release-24.05 branch June 19, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjornfor @woffs