-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move various packages out of gnome scope #319659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff and commits look good, and I'm not against this change, but I don't fully understand the motivation for it.
Mainly, the consensus of GNOME maintainers a long time ago was that the scope is more trouble than it’s worth:
Edit: Added a comment to the top of the scope. |
OK then, I fully support this PR. |
Can you please squash all those /Move from gnome scope to top-level/ commits into a single treewide one? |
I tend to like how there the PR is split to multiple commits - makes reviewing easier. |
Why are some packages still kept in gnome scope? And I thought we should add some aliases? |
It is lot of work so I am doing it in waves – more will be come later (help appreciated). Aliases should have been added – if I missed any we should fix that. |
Ah, sorry, I forgot that I disabled allowAliases. 🤦 it takes me some time to figure out which packages are moved and fix all of them. |
Flake lock file updates: • Updated input 'agenix': 'github:ryantm/agenix/3a56735779db467538fb2e577eda28a9daacaca6' (2024-06-14) → 'github:ryantm/agenix/de96bd907d5fbc3b14fc33ad37d1b9a3cb15edc6' (2024-07-09) • Updated input 'home-manager': 'github:nix-community/home-manager/59ce796b2563e19821361abbe2067c3bb4143a7d' (2024-07-01) → 'github:nix-community/home-manager/2fb5c1e0a17bc6059fa09dc411a43d75f35bb192' (2024-07-08) • Updated input 'nixpkgs': 'github:NixOS/nixpkgs/7f993cdf26ccef564eabf31fdb40d140821e12bc' (2024-07-01) → 'github:nixos/nixpkgs/655a58a72a6601292512670343087c2d75d859c1' (2024-07-08) - large `gnome` extraction (NixOS/nixpkgs#319659) - PAM module switched `u2f` to RFC42 settings (NixOS/nixpkgs#276106) - Proper GDM fingerprint support (NixOS/nixpkgs#324347)
The ``pkgs.gnome.gnome-terminal`` package was moved to ``pkgs.gnome-terminal``. The former is now a deprecated alias that throws a warning whenever a configuration enabling the module is used: ``` The ‘gnome.gnome-terminal’ was moved to top-level. Please use ‘pkgs.gnome-terminal’ directly. ``` Related: NixOS/nixpkgs#319659 Related: nix-community#5611
The `pkgs.gnome.gnome-terminal` package was moved to `pkgs.gnome-terminal`. The former is now a deprecated alias that throws a warning whenever a configuration enabling the module is used: ``` The ‘gnome.gnome-terminal’ was moved to top-level. Please use ‘pkgs.gnome-terminal’ directly. ``` Related: NixOS/nixpkgs#319659 Related: nix-community#5611
…ita-icon-theme` `adwaita-icon-theme` has been moved out of the `gnome` scope and into the top level with NixOS/nixpkgs#319659
…ita-icon-theme` in the examples `adwaita-icon-theme` has been moved out of the `gnome` scope and into the top level with NixOS/nixpkgs#319659
- Follow renaming of `pkgs.gnome.adwaita-icon-theme` to top level from upstream nixpkgs [1]. [1] NixOS/nixpkgs#319659
The `pkgs.gnome.gnome-terminal` package was moved to `pkgs.gnome-terminal`. The former is now a deprecated alias that throws a warning whenever a configuration enabling the module is used: ``` The ‘gnome.gnome-terminal’ was moved to top-level. Please use ‘pkgs.gnome-terminal’ directly. ``` Related: NixOS/nixpkgs#319659 Related: nix-community#5611
Description of changes
We have been slowly disbanding it since it offers little benefit.
Extracted from #319535
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.