Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feishin: upgrade electron to v30 #319470

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

jlbribeiro
Copy link
Member

@jlbribeiro jlbribeiro commented Jun 13, 2024

Description of changes

Feishin is currently using Electron v27, which is EOL since 2024/04/16.
Addresses #319252 by upgrading to Electron v30.

While it is currently not officially supported by upstream (jeffvli/feishin#643), I've tested Electron v30 and it seems to work fine.
(Skipped v29 since it will become EOL soon-ish.)

Maintainers: @onny (and I)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Addresses NixOS#319252: v27 has been EOL since 2024/04/16.
@onny
Copy link
Contributor

onny commented Jun 13, 2024

Result of nixpkgs-review pr 319470 run on x86_64-linux 1

1 package built:
  • feishin

@onny onny merged commit 50d28be into NixOS:master Jun 13, 2024
32 of 33 checks passed
@onny
Copy link
Contributor

onny commented Jun 13, 2024

Thank you!

@jlbribeiro jlbribeiro deleted the pkgs/feishin/electron-eol branch June 13, 2024 13:05
@jlbribeiro jlbribeiro mentioned this pull request Aug 2, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants