Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

voicevox: init at 0.20.0 #319403

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

voicevox: init at 0.20.0 #319403

wants to merge 3 commits into from

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Jun 12, 2024

Description of changes

Supersedes #287354

Homepage: https://voicevox.hiroshiba.jp
(I didn't put this homepage in the meta, since it's always 1 click away from the GitHub repo)


Note: downloading the voicevox_core prebuilt binaries takes a while.
Also note: the program's language is Japanese, so it might be difficult to navigate the program if you don't speak it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin (VM)
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@TomaSajt
Copy link
Contributor Author

TomaSajt commented Jun 14, 2024

For the record, before I add free = false: the CI seems to run fine
image

I didn't wait out aarch64-darwin, but I assume it's gonna build fine.

@sarahec
Copy link
Contributor

sarahec commented Sep 29, 2024

Result of nixpkgs-review pr 319403 run on aarch64-darwin 1

3 packages failed to build:
  • voicevox-core
  • voicevox-engine
  • voicevox-engine.dist

@TomaSajt TomaSajt force-pushed the voicevox branch 3 times, most recently from ff5a0d9 to 0a8d4e3 Compare September 30, 2024 20:38
@TomaSajt
Copy link
Contributor Author

I pushed some small changes.

One of them was changing stdenv.is* to stdenv.hostPlatform.is*

The other change was using replaceVars instead of substituteAll.
This change made me realize that substituteAll wasn't actually substituting _7zz_path and was leaving it as @_7zz_path@. replaceVars actually worked, because its implementation is just a wrapper for substitute --replace-fail @key@ value.
I changed the variable name to be less confusing, now both methods should work.

patches = [
# the package uses poetry for dependency management, but not package definition
# this patch makes the package installable via poetry-core
(replaceVars ./make-installable.patch {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any vars in the patch, so you should be able to remove replaceVars and just use the patch path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants