Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.neotest-playwright: add telescope dependency #319314

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Jun 12, 2024

Description of changes

As mentioned in their README, telescope.nvim is required.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 319314 run on aarch64-darwin 1

1 package built:
  • vimPlugins.neotest-playwright

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 319314 run on x86_64-darwin 1

1 package built:
  • vimPlugins.neotest-playwright

GaetanLepage added a commit to nix-community/nixvim that referenced this pull request Jun 12, 2024
@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 319314 run on aarch64-linux 1

1 package built:
  • vimPlugins.neotest-playwright

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 319314 run on x86_64-linux 1

1 package built:
  • vimPlugins.neotest-playwright

@GaetanLepage GaetanLepage requested a review from teto June 12, 2024 12:49
GaetanLepage added a commit to nix-community/nixvim that referenced this pull request Jun 12, 2024
@teto
Copy link
Member

teto commented Jun 12, 2024

I dont see telescope used in their demo, it seems to use the native neovim TUI vim.select ? Ain't that a convenience dependency ?

@GaetanLepage
Copy link
Contributor Author

I dont see telescope used in their demo, it seems to use the native neovim TUI vim.select ? Ain't that a convenience dependency ?

From the logs of the nixvim test suite, it seems necessary:
https://buildbot.nix-community.org/api/v2/logs/99776/raw_inline

GaetanLepage added a commit to nix-community/nixvim that referenced this pull request Jun 12, 2024
@teto
Copy link
Member

teto commented Jun 12, 2024

I see

From the logs of the nixvim test suite, it seems necessary:
https://buildbot.nix-community.org/api/v2/logs/99776/raw_inline

Would be nice to have a similar test in nixpkgs too. As you mentioned on chat, a requireCheck with neotest as dependency should catch this.

Copy link
Member

@teto teto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we tried to quickly add a test with @GaetanLepage but it seemed non trivial.
Hopefully #319325 will fix some stuff. We can revisit later.

Do as you prefer @GaetanLepage ;)

@GaetanLepage
Copy link
Contributor Author

Do as you prefer @GaetanLepage ;)

Yes, let us merge this as is. We'll see afterwards regarding testing as we might need the lua-paths fix...

4lxs pushed a commit to 4lxs/nixvim that referenced this pull request Jun 12, 2024
@GaetanLepage GaetanLepage merged commit 8d146a2 into NixOS:master Jun 13, 2024
39 of 40 checks passed
@GaetanLepage GaetanLepage deleted the neotest-playwright branch June 13, 2024 07:17
nfelber pushed a commit to nfelber/nixvim that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants