Fix failures with pkgs/top-level/release-attrpaths-superset.nix

[RossComputerGuy]

Description of changes

Fixes #319147

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[tomberek]

Adding optionalAttrs and protection from non-existent attribute.

[tomberek]

Looks better. Requesting @lheckemann as well, if available.

[lf-]

mostly lgtm but I'm not super stoked we're turning off an entire suite of which a lot looks applicable

[lf-]

I'm not the most pleased this entire suite is turned off on Darwin. It's ok if necessary but it's a little unfortunate.

[RossComputerGuy]

Yeah, it had a funky error without it.

[RossComputerGuy]

This shouldn't be an issue, idk why it's a problem. I kinda didn't feel like diving into figuring out why this was happening so the easiest solution was to just disable on Darwin. Linux targets work so this is a Darwin only issue. If this isn't a blocker and we can't find a solution before this PR is merged, a follow up PR to properly fix it should be fine.

error:
       … while calling the 'map' builtin

         at /home/ross/ExpidusOS/nixpkgs/pkgs/top-level/release-attrpaths-superset.nix:193:5:

          192|   names =
          193|     map (path: (lib.concatStringsSep "." path)) paths;
             |     ^
          194|

       … while evaluating a branch condition

         at /home/ross/ExpidusOS/nixpkgs/pkgs/top-level/release-attrpaths-superset.nix:162:9:

          161|       result =
          162|         if tried.success
             |         ^
          163|         then tried.value

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: attribute '__bootPackages' missing

       at /home/ross/ExpidusOS/nixpkgs/pkgs/test/stdenv/default.nix:13:17:

           12|   earlyPkgs = stdenv.__bootPackages.stdenv.__bootPackages;
           13|   earlierPkgs = stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages;
             |                 ^
           14|   # use a early stdenv so when hacking on stdenv this test can be run quickly

[lf-]

there's got to be a way to fix this better because __bootPackages is certainly not the only attr that is broken in the entirety of nixpkgs, right?? oh i see, this test seems to be making a bunch of pretty linuxy assumptions about the stdenv bootstrap structure.

but can you add a FIXME above that disabling, if you do want to defer it; with that change this is lgtm without figuring this out.

[lf-]

also cc @reckenrode as a darwin maintainer noting that this was deferred.

[RossComputerGuy]

but can you add a FIXME above that disabling, if you do want to defer it; with that change this is lgtm without figuring this out.

Will do.

[RossComputerGuy]

Added the note.