Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xunit-viewer: init at 10.6.1 #319020

Merged
merged 2 commits into from
Jun 16, 2024
Merged

xunit-viewer: init at 10.6.1 #319020

merged 2 commits into from
Jun 16, 2024

Conversation

pluiedev
Copy link
Contributor

Description of changes

Fixes #318811

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I've added tests to help automate part of the maintenance.

Just waiting for ofborg to eval now.

Thank you @pluiedev!

@roberth
Copy link
Member

roberth commented Jun 16, 2024

Also passes on aarch64-darwin.

@roberth roberth merged commit a94dfb6 into NixOS:master Jun 16, 2024
30 of 32 checks passed
@roberth
Copy link
Member

roberth commented Jun 16, 2024

Thanks again @pluiedev!

Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: xunit-viewer
3 participants