Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glock: migrate to buildGoModule #318572

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

luftmensch-luftmensch
Copy link
Contributor

Description of changes

Migrating to buildGoModule so buildGoPackage can be deprecated as cited in #318069

Updated also location of the package to reflect the newest standard

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/1016/138

@katexochen
Copy link
Contributor

I've rebased to resolve the merge conflict. Also fixed the versioning, which should use the date of the used commit (not including the patches).

@katexochen
Copy link
Contributor

Result of nixpkgs-review pr 318572 run on x86_64-linux 1

1 package built:
  • glock

@katexochen katexochen merged commit e2606ad into NixOS:master Jun 18, 2024
25 checks passed
@luftmensch-luftmensch luftmensch-luftmensch deleted the glock_update branch June 18, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants