Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syshud: init at 0-unstable-2024-06-20 #318440

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

uninsane
Copy link
Contributor

@uninsane uninsane commented Jun 9, 2024

Description of changes

syshud (formerly known as "sysvol") is a GTK4 volume indicator, similar to packages like wob, avizo, or swayosd. built for wayland and pipewire (or pulse -- if you pass PULSEAUDIO=1 to makeFlags -- but it can only be built for one or the other). nix-build -A syshud and run the binary, then adjust the system volume externally, and you should see an overlay like as shown on the project's readme.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@Sigmanificient Sigmanificient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the -v argument is broken:

sysvol -v
Commit: 
Date: 

pkgs/by-name/sy/sysvol/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sy/sysvol/package.nix Outdated Show resolved Hide resolved
@uninsane
Copy link
Contributor Author

uninsane commented Jun 9, 2024

Seems like the -v argument is broken:

should be fixed now; it would normally get these from git, so needed leaveDotGit = true i plumbed the rev and version fields from the nix expression through to git_info.hpp

$ sysvol -v
Commit: 56d7dcda4b246e71b2c6d29cbb2315bddf446032
Date: 2024-06-07

pkgs/by-name/sy/sysvol/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sy/sysvol/package.nix Outdated Show resolved Hide resolved
@uninsane uninsane force-pushed the pr-sysvol-init branch 3 times, most recently from 5dd2655 to 6603ed7 Compare June 15, 2024 00:30
@uninsane uninsane changed the title sysvol: init at 0-unstable-2024-06-07 sysvol: init at 0-unstable-2024-06-13 Jun 15, 2024
@uninsane uninsane force-pushed the pr-sysvol-init branch 2 times, most recently from f5ef809 to 47862fe Compare June 15, 2024 21:28
@uninsane uninsane changed the title sysvol: init at 0-unstable-2024-06-13 syshud: init at 0-unstable-2024-06-20 Jun 21, 2024
@Sigmanificient
Copy link
Member

Result of nixpkgs-review pr 318440 run on x86_64-linux 1

1 package built:
  • syshud

@SuperSandro2000 SuperSandro2000 merged commit 339d32d into NixOS:master Jun 25, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants