[backport release-24.05] sftpgo: mark as unfreeRedistributable #315671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cherry-pick check most likely failed due to having to resolve a conflict, which changed the commit hash. (Is this something new or was this always? I don't have much experience with backports, so I can't really tell.) |
|
Actually, no, the commit hash that was merged is different, even though diff is the same. Perhaps @yayayayaka rebased the branch before merging the original PR? That would explain the different commit hash. |
|
Can you try cherry-picking bd887df instead? |
|
Yes it was a rebase-merge by the looks of it and bd887df should be referenced instead. |
Resolves NixOS#315154. New Web UI uses an unfree web theme, and as a result it... > is allowed for use only within the SFTPGo product and therefore > cannot be used in derivative works/products without an explicit > grant from the SFTPGo Team ([email protected]). This makes the entire package unfree, which the [SFTPGo license compliance page][1] supports: > If you modify SFTPGo's source code and are therefore creating a > derivative work: > > 1. ... > 2. ... > 3. You cannot use the UI theme based on KeenThemes because it is > based on a proprietary theme that we purchased and the WebAdmin and > WebClient components created using this theme can only be used only > within SFTPGo and not in derivative works. You must develop and > maintain your own UI components or adapt the WebAdmin/WebClient > included in SFTPGo up to version 2.5.6. @JohnRTitor noted that building from source might not be derivative work, therefore marking as `unfreeRedistributable`. [1]: https://sftpgo.com/compliance.html Co-authored-by: Masum Reza <[email protected]> (cherry picked from commit bd887df)
185a8e3
to
c4f4312
Compare
|
I apologize for the delay. The cherry-pick check should be appeased now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Manual backport of #315159 to release-24.05.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.