-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python311Packages.rfeed, python312Packages.rfeed: init at 1.1.1 #315113
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, according to https://github.com/egorsmkv/rfeed, which is linked in Pypi to rfeed
, it's unmaintained for 8 years and has been archived since 2022. Should it be added to nixpkgs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a rather small package but it provides a nice API that I'm personally using. As far as I'm aware it hasn't been updated because no changes have needed to be made, which is kinda the idea when it comes to software. It doesn't do any networking itself so there are no possible security vulnerabilities there.
@@ -0,0 +1,30 @@ | |||
{ lib | |||
, buildPythonPackage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please format with the new formatter.
--replace-fail distutils.core setuptools | ||
''; | ||
meta = { | ||
description = "Extensible RSS 2.0 Feed Generator written in Python."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "Extensible RSS 2.0 Feed Generator written in Python."; | |
description = "Extensible RSS 2.0 Feed Generator"; |
downloadPage = "https://github.com/egorsmkv/rfeed/releases"; | ||
homepage = "https://github.com/egorsmkv/rfeed"; | ||
license = lib.licenses.mit; | ||
maintainers = with lib.maintainers; [ ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New packages must have a maintainer.
Description of changes
https://github.com/svpino/rfeed
In my opinion, I prefer rfeed to
feedgen
or other packages.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.