Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.rfeed, python312Packages.rfeed: init at 1.1.1 #315113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

expenses
Copy link
Contributor

Description of changes

https://github.com/svpino/rfeed

rfeed is a library to generate RSS 2.0 feeds in Python. ...

rfeed is extensible, and in my opinion very easy to use. Besides the standard RSS 2.0 specification, it also includes iTunes support for podcast feeds.

In my opinion, I prefer rfeed to feedgen or other packages.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@Moraxyc Moraxyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! some suggestions

pkgs/development/python-modules/rfeed/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/rfeed/default.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@Moraxyc Moraxyc Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, according to https://github.com/egorsmkv/rfeed, which is linked in Pypi to rfeed, it's unmaintained for 8 years and has been archived since 2022. Should it be added to nixpkgs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a rather small package but it provides a nice API that I'm personally using. As far as I'm aware it hasn't been updated because no changes have needed to be made, which is kinda the idea when it comes to software. It doesn't do any networking itself so there are no possible security vulnerabilities there.

pkgs/development/python-modules/rfeed/default.nix Outdated Show resolved Hide resolved
@@ -0,0 +1,30 @@
{ lib
, buildPythonPackage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format with the new formatter.

--replace-fail distutils.core setuptools
'';
meta = {
description = "Extensible RSS 2.0 Feed Generator written in Python.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "Extensible RSS 2.0 Feed Generator written in Python.";
description = "Extensible RSS 2.0 Feed Generator";

downloadPage = "https://github.com/egorsmkv/rfeed/releases";
homepage = "https://github.com/egorsmkv/rfeed";
license = lib.licenses.mit;
maintainers = with lib.maintainers; [ ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New packages must have a maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants