xonsh: 0.15.1 -> 0.17.0 #314728
Merged
xonsh: 0.15.1 -> 0.17.0 #314728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamLukeYes
commented
May 26, 2024
Aleksanaa
reviewed
May 26, 2024
There was a problem hiding this comment.
Maybe also put the compare link in the PR message:
xonsh/xonsh@0.15.1...1613914
LordGrimmauld
approved these changes
May 26, 2024
|
Can this move to |
And using an outdated prompt-toolkit in a wild override stack that will be removed in the next release? Nope. |
AndersonTorres
approved these changes
Jun 18, 2024
|
0.17.0 was released just now. Let's use this stable version instead. |
Co-authored-by: Anderson Torres <[email protected]> Upstream changes: xonsh/xonsh@0.15.1...0.17.0
AndersonTorres
approved these changes
Jun 18, 2024
|
LGTM |
|
Can we backport this to 24.05? |
I'm not so sure about it tho, as it introduces at least one breaking change (xonsh/xonsh#5491) |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-314728-to-release-24.05 origin/release-24.05
cd .worktree/backport-314728-to-release-24.05
git switch --create backport-314728-to-release-24.05
git cherry-pick -x afc31073a3bb5d61825c51cadc67f75ab4d65ed0 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adopted from #305316
Fixes #308868
Fixes #206062
Closes #301670
Upstream changes: xonsh/xonsh@0.15.1...0.17.0
Notably,
~/.xonshrcis no longer loaded by default in non-interactive mode. See xonsh/xonsh#5491Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.