Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-23.11] rbw: 1.10.1 -> 1.10.2 #313591

Conversation

minijackson
Copy link
Member

Description of changes

See #313364

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

7 packages built:
  • rbw
  • rofi-rbw
  • rofi-rbw-wayland
  • rofi-rbw-wayland.dist
  • rofi-rbw-x11
  • rofi-rbw-x11.dist
  • rofi-rbw.dist

Add a 👍 reaction to pull requests you find important.

@risicle
Copy link
Contributor

risicle commented May 26, 2024

Generally, if you're backporting bumps it's better to cherry-pick each corresponding bump-commit in order from unstable, so the respective cherry-pick references are correct.

Also, you could consider just applying the patch that fixes your issue (doy/rbw@d158055 ?) using fetchpatch to avoid bumping the stable version.

@minijackson minijackson force-pushed the backport-313364-to-release-23.11 branch from 02a6d50 to 0dec334 Compare June 6, 2024 08:35
@minijackson
Copy link
Member Author

I've cherry-picked all the related commits. Note that this doesn't change the major version, only the minor one. I've also added the commit for using rust 1.76 separately, as it isn't needed on master.

@minijackson minijackson changed the title Backport #313364 to release 23.11 [Backport release-23.11] rbw: 1.10.1 -> 1.10.2 Jun 13, 2024
@wegank
Copy link
Member

wegank commented Jun 30, 2024

As NixOS 23.11 reaches end-of-life today, this PR is closed as part of the EOL cleanup.

@wegank wegank closed this Jun 30, 2024
@minijackson minijackson deleted the backport-313364-to-release-23.11 branch July 31, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants