Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eyewitness: init at 20230525.1 #308431

Merged
merged 1 commit into from
Jun 26, 2024
Merged

eyewitness: init at 20230525.1 #308431

merged 1 commit into from
Jun 26, 2024

Conversation

Tochiaha
Copy link
Contributor

@Tochiaha Tochiaha commented May 2, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

SuperSandro2000
SuperSandro2000 requested changes May 2, 2024
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits

pkgs/by-name/ey/eyewitness/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ey/eyewitness/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ey/eyewitness/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ey/eyewitness/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ey/eyewitness/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ey/eyewitness/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ey/eyewitness/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ey/eyewitness/package.nix Outdated Show resolved Hide resolved
@Tochiaha Tochiaha force-pushed the eyewitness branch 2 times, most recently from de1f990 to 91d0f4a Compare May 2, 2024 20:15
@Tochiaha
Copy link
Contributor Author

Tochiaha commented May 2, 2024

#81418

@Tochiaha
Copy link
Contributor Author

Tochiaha commented May 4, 2024 •
edited
Loading

@wegank

@Tochiaha Tochiaha requested a review from wegank May 13, 2024 16:36
@wegank wegank requested review from SuperSandro2000 and removed request for SuperSandro2000 May 13, 2024 21:50
@Tochiaha Tochiaha force-pushed the eyewitness branch 2 times, most recently from 699d4d8 to 2722339 Compare May 14, 2024 03:18
@Tochiaha
Copy link
Contributor Author

Tochiaha commented Jun 9, 2024 •
edited
Loading

Please squash the commits

Commits squashed @SuperSandro2000 .

SuperSandro2000
SuperSandro2000 reviewed Jun 10, 2024
View reviewed changes
pkgs/by-name/ey/eyewitness/package.nix Outdated
python3Packages.buildPythonApplication rec {
pname = "eye-witness";
version = "20230525.1";
pyproject = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pyproject = false;
format = "other";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thank you!

@Tochiaha
Copy link
Contributor Author

Please squash the commits

Commits squashed.

@SuperSandro2000 SuperSandro2000 merged commit 49cc34e into NixOS:master Jun 26, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@wegank wegank Awaiting requested review from wegank

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tochiaha @SuperSandro2000 @wegank @Aleksanaa