mediathekview: build from source #306292
mediathekview: build from source #306292
Conversation
42fcccd
to
784f982
Compare
9ae20ae
to
fb88b32
Compare
| { | ||
| x86_64-linux = "-Plinux_64bit"; | ||
| aarch64-linux = "-Plinux_arm_64bit"; | ||
| }.${stdenv.hostPlatform.system} |
There was a problem hiding this comment.
I guess this would fail on other platforms. We should change meta.platforms to those two as well. Do you have an idea why the hash isn't the same? Are there sharedibs that are included into the jar?
There was a problem hiding this comment.
tbh, I haven't had a deeper look into this and I am not sure how to handle this properly for different architectures. Any suggestion welcome.
Is it acceptable to change:
- platforms = lib.platforms.linux;
+ platforms = [ "x86_64-linux" "aarch64-linux" ];
Or completely remove aarch64-linux?
| makeWrapper ${jre}/bin/java $out/bin/MediathekView_ipv4 \ | ||
| --add-flags "-Djava.net.preferIPv4Stack=true -jar $out/lib/MediathekView.jar" \ | ||
| --suffix LD_LIBRARY_PATH : "${libraryPath}" | ||
| makeShellWrapper ${jdk}/bin/java $out/bin/mediathek \ |
There was a problem hiding this comment.
Upstream this is MediathekView now. I think we should change it as well.
There was a problem hiding this comment.
Do you mean to include the mediathek_ipv4? This is not part of the appimage instructions, but mentioned in the troubleshoot guide. My intention was to be close to appimage creation and if somebody runs into IPv6 issues to use overwrite. But I am open to suggestions.
| --add-flags "-XX:+UseStringDeduplication" \ | ||
| --add-flags "-XX:MaxRAMPercentage=50.0" \ | ||
| --add-flags "--add-opens java.desktop/sun.awt.X11=ALL-UNNAMED" \ | ||
| --add-flags "-DexternalUpdateCheck" \ |
There was a problem hiding this comment.
Does this enable or disable update checks in the app itself?
There was a problem hiding this comment.
This is by default set in appimage → https://github.com/mediathekview/MediathekView/blob/master/scripte/appimage.sh.
"Check whether or not we are using Install4j's external update mechanism." In the UI mentions with this parameter set, that an external updater is used.
fb88b32
to
0de3abb
Compare
0de3abb
to
866e047
Compare
Description of changes
libnotify,libXxf86vm,libglvnd)Things done
Built and execution successfully and is usable.
Add a 👍 reaction to pull requests you find important.