gvmd: init at 23.4.0 #303758

Tochiaha · 2024-04-13T02:14:40Z

Release: https://github.com/greenbone/gvmd/releases/tag/v23.4.0

Things done

Add a 👍 reaction to pull requests you find important.

Tochiaha · 2024-04-13T02:24:50Z

referencing #81418

pkgs/by-name/gv/gvmd/package.nix

Aleksanaa · 2024-04-17T17:19:57Z

pkgs/by-name/gv/gvmd/package.nix

+
+ buildPhase = ''
+ substituteInPlace $src/src/sql_pg.c --replace "#include postgresql/libpq-fe.h" "#include ${postgresql}/include/libpq-fe.h"
+ mkdir -p $out/{bin,etc,sbin,lib,usr/{share,include},run/gvmd/gvmd.pid}


share and include are expected in $out, not $out/usr. Is there a particular reason not to use this?

no need for the $out/usr will rely on the cmakeflags destination.

pkgs/by-name/gv/gvmd/package.nix

Tochiaha · 2024-04-18T17:03:31Z

#305096 needed for gvmd

nixos-discourse · 2024-06-11T00:53:35Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4075

Aleksanaa · 2024-07-04T04:16:37Z

pkgs/by-name/gv/gvmd/package.nix

+ '';
+
+ meta = with lib; {
+ description = "The central management service between security scanners and the user clients";


Suggested change

description = "The central management service between security scanners and the user clients";

description = "Central management service between security scanners and the user clients";

The policy has changed https://github.com/NixOS/nixpkgs/tree/master/pkgs#meta-attributes

Aleksanaa · 2024-07-04T04:17:27Z

pkgs/by-name/gv/gvmd/package.nix

+ postInstall = ''
+ mkdir -p \
+ $out/var/lib/gvm/gvmd/gvm-checking \
+ $out/run/gvmd/gvmd.pid


These two should not be needed. If there is a reason, write in the comment above postInstall.

what will be the best way to approach this error. reason for the postintsall.

pkgs/by-name/gv/gvmd/package.nix

Tochiaha · 2024-07-23T17:36:13Z

In between build time Flags are what's left.

pkgs/by-name/gv/gvmd/package.nix

superherointj · 2024-07-23T19:18:21Z

@Tochiaha Please, ask someone else to review this PR. The inputs I could offer, I already did. And I don't really understand how this application works. And how things are arranged. So my judgement here is not a good one.

I don't know.

Tochiaha · 2024-07-23T19:39:40Z

for reference it needs some other GVM package and Pgsql from this https://greenbone.github.io/docs/latest/22.4/source-build/index.html#id115 line down shows the setup. also when "gvmd --create-user=admin --password=''" is used it logs error regading roles and user for DB pgsql in $out/var/log/gvm/gvmd.log and run time. creating user and role with Pgsql and executing "gvmd --create-user=admin --password=''" results in this ouput "User created" which shows build time and runtime successful for gvmd. Achitecture for gvm can be seen here for better understanding https://greenbone.github.io/docs/latest/architecture.html#id1

Tochiaha · 2024-07-23T19:40:51Z

As recommended @fabaff can help he done other required packages of GVM.

superherointj · 2024-07-24T07:34:58Z

for reference it needs some other GVM package and Pgsql from this https://greenbone.github.io/docs/latest/22.4/source-build/index.html#id115 line down shows the setup. also when "gvmd --create-user=admin --password=''" is used it logs error regading roles and user for DB pgsql in $out/var/log/gvm/gvmd.log and run time. creating user and role with Pgsql and executing "gvmd --create-user=admin --password=''" results in this ouput "User created" which shows build time and runtime successful for gvmd. Achitecture for gvm can be seen here for better understanding https://greenbone.github.io/docs/latest/architecture.html#id1

I really don't understand what you are doing.

$out/var/log/gvm/gvmd.log

This makes no sense to me. Because the nix store is not writable. How/why are you saving logs there?

My guess is, you are packaging a service which needs a NixOS module. I've already tried to explain to you this. Continuously I see red flags in what you are doing. And you don't seem to understand what I tell you.

There is a distinction between what is to be done at build time and what is to be done at runtime. And a package is not part of the runtime. Any runtime consideration should be sorted at a NixOS module. The package can only set a default value. It's static.

So far you have not answered how you are executing the application. How is this being run at runtime? Why you continuously add runtime concerns to a package?

I don't have context of this application. I think you need feedback from someone that knows best. Which is not me. Still. I highly recommend you to add other reviews. I think, you should seek help. Particularly from someone that understand what you are doing.

pkgs/by-name/gv/gvmd/package.nix

superherointj · 2024-07-24T08:23:50Z

@Tochiaha

How is this application being executed?
Is this a service?
If this is a service, consider a NixOS service module for it.
Add more reviewers. (We need feedback here.)

Release: https://github.com/greenbone/gvmd/releases/tag/v23.4.0

superherointj · 2024-07-24T15:42:15Z

Most of these parameters shouldn't go to the nix store. The package is just a default value for these parameters. And it should be a standard system parameter, no $out (which is nix store). Then, there are the runtime concerns I told you. Which is separate of the package.

superherointj · 2024-07-24T15:44:01Z

pkgs/by-name/gv/gvmd/package.nix

+ -DDATADIR=$out/share \
+ -DGVM_SYSCONF_DIR=$out/etc/gvm \
+ -DGVM_DATA_DIR=$out/share/gvm \
+ -DGVM_STATE_DIR=$out/var/lib/gvm \


State in the nix store?

superherointj · 2024-07-24T15:44:24Z

pkgs/by-name/gv/gvmd/package.nix

+ -DGVMD_MAN_DIR=$out/share \
+ -DDATADIR=$out/share \
+ -DGVM_SYSCONF_DIR=$out/etc/gvm \
+ -DGVM_DATA_DIR=$out/share/gvm \


Which kind of data is this?

superherointj · 2024-07-24T15:44:41Z

pkgs/by-name/gv/gvmd/package.nix

+ -DINCLUDEDIR=$out/include \
+ -DGMP_DIR=$out/share \
+ -DGVMD_MAN_DIR=$out/share \
+ -DDATADIR=$out/share \


Suggested change

-DDATADIR=$out/share \

-DDATADIR=$out/share \

Which kind of data is this?

without it result to https://termbin.com/bdhv

superherointj · 2024-07-24T15:44:56Z

pkgs/by-name/gv/gvmd/package.nix

+ -DBINDIR=$out/bin \
+ -DSBINDIR=$out/sbin \
+ -DLIBDIR=$out/lib \
+ -DLOCALSTATEDIR=$out/var \


Suggested change

-DLOCALSTATEDIR=$out/var \

-DLOCALSTATEDIR=$out/var \

State in the nix store?

without it result to https://termbin.com/bdhv

superherointj · 2024-07-24T15:45:14Z

pkgs/by-name/gv/gvmd/package.nix

+ -DGVM_SYSCONF_DIR=$out/etc/gvm \
+ -DGVM_DATA_DIR=$out/share/gvm \
+ -DGVM_STATE_DIR=$out/var/lib/gvm \
+ -DGVMD_STATE_DIR=$out/var/lib/gvm/gvmd \


Suggested change

-DGVMD_STATE_DIR=$out/var/lib/gvm/gvmd \

-DGVMD_STATE_DIR=$out/var/lib/gvm/gvmd \

State in the nix store?

superherointj · 2024-07-24T15:45:36Z

pkgs/by-name/gv/gvmd/package.nix

+ -DGVM_STATE_DIR=$out/var/lib/gvm \
+ -DGVMD_STATE_DIR=$out/var/lib/gvm/gvmd \
+ -DGVM_LIB_INSTALL_DIR=$out/lib \
+ -DGVMD_RUN_DIR=$out/run/gvmd \


Suggested change

-DGVMD_RUN_DIR=$out/run/gvmd \

-DGVMD_RUN_DIR=$out/run/gvmd \

Is it a pid? If it is it shouldn't be in the nix store.

What is this?

Tochiaha · 2024-07-24T17:09:12Z

@Tochiaha

1. How is this application being executed?

2. Is this a service?

3. If this is a service, consider a NixOS service module for it.

4. Add more reviewers. (We need feedback here.)

i can still do NixOS service module but consider this https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/tools/security/ospd-openvas/default.nix#L45 @mweinelt any help here?

mweinelt · 2024-07-24T17:14:40Z

Not interested in this package. Did only contribute a drive-by fix.

Tochiaha · 2024-07-24T17:17:18Z

Thank you.

superherointj · 2024-07-26T14:41:12Z

i can still do NixOS service module but consider this https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/tools/security/ospd-openvas/default.nix#L45 @mweinelt any help here?

The NixOS module may be optional, but offering invalid paths as default paths for package was the main issue.
nix store paths are read only, hence no pid, socks, logs, state, data?.
In the package, you can only hard code paths.
To pass through customized paths, a NixOS module is convenient, particularly for runtime considerations.

Note that, at this point in time, we are seeking to clarify the arguments purposes and values. I have asked you several questions (for each argument). Try to answer them. We need to clarify if these arguments are correct. Once that is done, I don't have objections with this PR.

Tochiaha · 2024-07-26T16:00:49Z

Working on it.

superherointj · 2024-07-26T16:11:08Z

pkgs/by-name/gv/gvmd/package.nix

+
+ preFixup = ''
+ substituteInPlace $out/lib/systemd/system/gvmd.service \
+ --replace-fail "/run/ospd/ospd-openvas.sock" "${ospd-openvas}/run/ospd/ospd-openvas.sock"


A sock shouldn't exist in the nix store... That wouldn't be write-able.

wolfgangwalther · 2024-09-27T18:47:05Z

pkgs/by-name/gv/gvmd/package.nix

+ substituteInPlace src/sql_pg.c \
+ --replace-fail "#include <postgresql/libpq-fe.h>" "#include <${postgresql}/include/libpq-fe.h>"


Suggested change

substituteInPlace src/sql_pg.c \

--replace-fail "#include <postgresql/libpq-fe.h>" "#include <${postgresql}/include/libpq-fe.h>"

substituteInPlace src/sql_pg.c \

--replace-fail "#include <postgresql/libpq-fe.h>" "#include <libpq-fe.h>"

This fixes it for me already. But this should really be raised upstream, I think.

Tochiaha changed the title ~~openvas: init at 23.4.0~~ gvmd: init at 23.4.0 Apr 13, 2024

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 13, 2024

fabaff mentioned this pull request Apr 13, 2024

NixOS for Pentesting Overview #81418

Open

matthiasbeyer reviewed Apr 14, 2024

View reviewed changes

pkgs/by-name/gv/gvmd/package.nix Outdated Show resolved Hide resolved

Tochiaha force-pushed the gvmd branch 2 times, most recently from 8a762c8 to f845c22 Compare April 15, 2024 15:03

Aleksanaa reviewed Apr 17, 2024

View reviewed changes

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 labels Apr 18, 2024

Tochiaha force-pushed the gvmd branch 6 times, most recently from ced0f63 to 9bc5d03 Compare April 24, 2024 14:48

Tochiaha force-pushed the gvmd branch from 065a82b to 8813184 Compare May 4, 2024 03:17

Tochiaha force-pushed the gvmd branch from 3894a17 to 7ae8555 Compare June 9, 2024 21:57

Tochiaha force-pushed the gvmd branch from 85393ad to 46a7260 Compare July 4, 2024 04:16

Aleksanaa reviewed Jul 4, 2024

View reviewed changes

Tochiaha force-pushed the gvmd branch 2 times, most recently from f1da724 to 6c10d5b Compare July 6, 2024 15:45

superherointj reviewed Jul 20, 2024

View reviewed changes

pkgs/by-name/gv/gvmd/package.nix Outdated Show resolved Hide resolved

Tochiaha requested a review from superherointj July 23, 2024 17:30

Tochiaha force-pushed the gvmd branch from 524eea4 to c325ce2 Compare July 23, 2024 17:33

superherointj reviewed Jul 23, 2024

View reviewed changes

pkgs/by-name/gv/gvmd/package.nix Outdated Show resolved Hide resolved

Tochiaha force-pushed the gvmd branch from 96ea45b to 77e01cd Compare July 23, 2024 18:41

superherointj marked this pull request as ready for review July 23, 2024 22:56

Aleksanaa reviewed Jul 24, 2024

View reviewed changes

pkgs/by-name/gv/gvmd/package.nix Outdated Show resolved Hide resolved

gvmd: init at 23.4.0

c3b2913

Release: https://github.com/greenbone/gvmd/releases/tag/v23.4.0

Tochiaha force-pushed the gvmd branch from 594ea82 to c3b2913 Compare July 24, 2024 14:38

superherointj reviewed Jul 24, 2024

View reviewed changes

superherointj reviewed Jul 26, 2024

View reviewed changes

superherointj marked this pull request as draft August 2, 2024 14:41

wolfgangwalther reviewed Sep 27, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gvmd: init at 23.4.0 #303758

gvmd: init at 23.4.0 #303758

Tochiaha commented Apr 13, 2024 •

edited

Loading

Tochiaha commented Apr 13, 2024

Aleksanaa Apr 17, 2024

Tochiaha Apr 18, 2024

Tochiaha commented Apr 18, 2024

nixos-discourse commented Jun 11, 2024

Aleksanaa Jul 4, 2024

Aleksanaa Jul 4, 2024

Tochiaha Jul 4, 2024 •

edited

Loading

Tochiaha commented Jul 23, 2024

superherointj commented Jul 23, 2024

Tochiaha commented Jul 23, 2024

Tochiaha commented Jul 23, 2024

superherointj commented Jul 24, 2024 •

edited

Loading

superherointj commented Jul 24, 2024 •

edited

Loading

superherointj commented Jul 24, 2024 •

edited

Loading

superherointj Jul 24, 2024

superherointj Jul 24, 2024 •

edited

Loading

superherointj Jul 24, 2024 •

edited

Loading

Tochiaha Jul 24, 2024

superherointj Jul 24, 2024

Tochiaha Jul 24, 2024

superherointj Jul 24, 2024

superherointj Jul 24, 2024

superherointj Jul 26, 2024

Tochiaha commented Jul 24, 2024 •

edited

Loading

mweinelt commented Jul 24, 2024

Tochiaha commented Jul 24, 2024

superherointj commented Jul 26, 2024 •

edited

Loading

Tochiaha commented Jul 26, 2024

superherointj Jul 26, 2024

wolfgangwalther Sep 27, 2024

	description = "The central management service between security scanners and the user clients";
	description = "Central management service between security scanners and the user clients";

	-DGVMD_STATE_DIR=$out/var/lib/gvm/gvmd \
	-DGVMD_STATE_DIR=$out/var/lib/gvm/gvmd \

	-DGVMD_RUN_DIR=$out/run/gvmd \
	-DGVMD_RUN_DIR=$out/run/gvmd \

		substituteInPlace src/sql_pg.c \
		--replace-fail "#include <postgresql/libpq-fe.h>" "#include <${postgresql}/include/libpq-fe.h>"

gvmd: init at 23.4.0 #303758

Are you sure you want to change the base?

gvmd: init at 23.4.0 #303758

Conversation

Tochiaha commented Apr 13, 2024 • edited Loading

Things done

Tochiaha commented Apr 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tochiaha commented Apr 18, 2024

nixos-discourse commented Jun 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tochiaha Jul 4, 2024 • edited Loading

Choose a reason for hiding this comment

Tochiaha commented Jul 23, 2024

superherointj commented Jul 23, 2024

Tochiaha commented Jul 23, 2024

Tochiaha commented Jul 23, 2024

superherointj commented Jul 24, 2024 • edited Loading

superherointj commented Jul 24, 2024 • edited Loading

superherointj commented Jul 24, 2024 • edited Loading

Choose a reason for hiding this comment

superherointj Jul 24, 2024 • edited Loading

Choose a reason for hiding this comment

superherointj Jul 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tochiaha commented Jul 24, 2024 • edited Loading

mweinelt commented Jul 24, 2024

Tochiaha commented Jul 24, 2024

superherointj commented Jul 26, 2024 • edited Loading

Tochiaha commented Jul 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tochiaha commented Apr 13, 2024 •

edited

Loading

Tochiaha Jul 4, 2024 •

edited

Loading

superherointj commented Jul 24, 2024 •

edited

Loading

superherointj commented Jul 24, 2024 •

edited

Loading

superherointj commented Jul 24, 2024 •

edited

Loading

superherointj Jul 24, 2024 •

edited

Loading

superherointj Jul 24, 2024 •

edited

Loading

Tochiaha commented Jul 24, 2024 •

edited

Loading

superherointj commented Jul 26, 2024 •

edited

Loading