Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.opnieuw: init at 3.0.0 #303324

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

duijf
Copy link
Contributor

@duijf duijf commented Apr 11, 2024

Description of changes

Opnieuw is a Python retry library. This PR adds it to the Python package set.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@duijf
Copy link
Contributor Author

duijf commented Apr 11, 2024

It would be nice if this could be backported to 23.11, but I'm not sure if that is usually done for Python packages.

@arianvp
Copy link
Member

arianvp commented Apr 11, 2024

@GrahamcOfBorg build python3Packages.opnieuw

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Apr 11, 2024
@ofborg ofborg bot requested a review from arianvp April 11, 2024 10:54
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 11, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 3, 2024
@Scrumplex Scrumplex removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 15, 2024
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Nov 16, 2024
@duijf duijf requested a review from Scrumplex November 16, 2024 11:51
@nix-owners nix-owners bot requested a review from natsukium November 16, 2024 11:51
@Scrumplex
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 303324


x86_64-linux

✅ 4 packages built:
  • python311Packages.opnieuw
  • python311Packages.opnieuw.dist
  • python312Packages.opnieuw
  • python312Packages.opnieuw.dist

x86_64-darwin

✅ 4 packages built:
  • python311Packages.opnieuw
  • python311Packages.opnieuw.dist
  • python312Packages.opnieuw
  • python312Packages.opnieuw.dist

aarch64-darwin

✅ 4 packages built:
  • python311Packages.opnieuw
  • python311Packages.opnieuw.dist
  • python312Packages.opnieuw
  • python312Packages.opnieuw.dist

Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

sha256 = "sha256-BxhSz+AsL7lU3zw9tIL2R+Pxktb8NG2/UKPtEDJT+Qo=";
};

propagatedBuildInputs = [ typing-extensions ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
propagatedBuildInputs = [ typing-extensions ];
propagatedBuildInputs = [ typing-extensions ];
pythonImportsCheck = [ "opnieuw" ];

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants