-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.opnieuw: init at 3.0.0 #303324
base: master
Are you sure you want to change the base?
Conversation
It would be nice if this could be backported to 23.11, but I'm not sure if that is usually done for Python packages. |
@GrahamcOfBorg build python3Packages.opnieuw |
96f2173
to
b570c4d
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
sha256 = "sha256-BxhSz+AsL7lU3zw9tIL2R+Pxktb8NG2/UKPtEDJT+Qo="; | ||
}; | ||
|
||
propagatedBuildInputs = [ typing-extensions ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
propagatedBuildInputs = [ typing-extensions ]; | |
propagatedBuildInputs = [ typing-extensions ]; | |
pythonImportsCheck = [ "opnieuw" ]; |
Description of changes
Opnieuw is a Python retry library. This PR adds it to the Python package set.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.