Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickwit: 0.8.0 -> 0.8.1, default config file #300660

Closed
wants to merge 3 commits into from

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Apr 1, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nh2 nh2 requested a review from happysalada April 1, 2024 11:18
@nh2 nh2 self-assigned this Apr 1, 2024
@nh2
Copy link
Contributor Author

nh2 commented Apr 1, 2024

Building this still fails on my 128 GB RAM machine with:

thread 'actors::indexer::tests::test_indexer_triggers_commit_on_timeout' panicked at quickwit-indexing/src/actors/indexer.rs:1039:9:
assertion `left == right` failed
  left: MemoryLimit
 right: Timeout

See: #289000 (comment)

@happysalada
Copy link
Contributor

I observed the same failure when building 0.8.0
Let's skip this test if that's ok with you.

@nh2
Copy link
Contributor Author

nh2 commented Apr 3, 2024

Let's skip this test if that's ok with you.

Fine by me, I don't know yet how to disable specific Rust tests though. Feel free to push into my PR here in case you know it!

@happysalada
Copy link
Contributor

I'm not close to a keyboard for long enough to push a commit, but here is an example.

  checkFlags = [
    # tries to make a network access
    "--skip=sinks::loki::tests::healthcheck_grafana_cloud"

so it shoulb be something like --skip='actors::indexer::tests::test_indexer_triggers_commit_on_timeout

I should have time this weekend, I'm just posting this in case you have time before.

@tcheronneau
Copy link
Contributor

Hey guys I've been trying to build quickwit with the UI (and finally managed to do it).
I've also added the recommended build-features. Maybe it would worth to add that with this PR ?

@happysalada
Copy link
Contributor

That would indeed be appreciated. Would you he okay with pushing to the branch ?

@nh2
Copy link
Contributor Author

nh2 commented May 4, 2024

@tcheronneau I already left some comments on your PR #307808

@nh2
Copy link
Contributor Author

nh2 commented May 4, 2024

Hey guys I've been trying to build quickwit with the UI (and finally managed to do it).
I've also added the recommended build-features

@tcheronneau Where are those changes, do you have a branch? Feel free to push them into this PR as additional commits for me to review, if you have permission to do that. Otherwise, let me know and I'll pull them.

@tcheronneau
Copy link
Contributor

Hey guys I've been trying to build quickwit with the UI (and finally managed to do it).
I've also added the recommended build-features

@tcheronneau Where are those changes, do you have a branch? Feel free to push them into this PR as additional commits for me to review, if you have permission to do that. Otherwise, let me know and I'll pull them.

@nh2 I don't really know how to come in your PR (not used to github).
But you can find the change there : be916fc.

@tcheronneau
Copy link
Contributor

I've prepared a PR but I cannot push to your repo.
In the end the build features does not work for now.
I'll try to debug I got a dev from quickwit I could maybe contact to help.
For now the working package with UI is there : https://gist.github.com/tcheronneau/8c0417705e8acc28e37289255dbb6b45

@jpds
Copy link
Contributor

jpds commented Jun 16, 2024

Sorry folks - I didn't see this one when I pushed up #317152.

@wegank
Copy link
Member

wegank commented Jul 3, 2024

Done in #317152.

@wegank wegank closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants