chromium: vulkan is not an allowed implementation

[tlvince]

Describe the bug

vaapi on amd cards requires --use-angle=vulkan.

Steps To Reproduce

Steps to reproduce the behavior:

In wayland, with NIXOS_OZONE_WL=1:

❯ chromium --use-angle=vulkan
[6893:6893:0615/112355.605938:ERROR:gl_factory.cc(120)] Requested GL implementation (gl=egl-angle,angle=vulkan) not found in allowed implementations: [(gl=egl-angle,angle=opengl),(gl=egl-angle,angle=opengles),(gl=egl-gles2,angle=none),(gl=egl-angle,angle=swiftshader)].

Expected behavior

vulkan to be allowed

Additional context

Per upstream issue, a one-liner patch is needed to enable it.

Arch Linux recently added it.

Now that #306791 is in nixos-unstable, now's a good time to enable this.

Note, upstream did revert the change - there's probably some edge case, but it requires --use-angle=vulkan to be explicitly passed and AFAIK, there are no bug reports from Arch Linux users. It's very useful for AMD users.

Notify maintainers

@emilylange, @networkException, @Kiskae

---

Add a 👍 reaction to issues you find important.

[eclairevoyant]

there are no bug reports from Arch Linux users

To be fair, it was only added 2 weeks ago, so that might not really be a huge data point either way.
https://gitlab.archlinux.org/archlinux/packaging/packages/chromium/-/commit/07e8575a6f2151055d480a7578687704c72019f2

[tlvince]

That's fair, though if I'm following the upstream issue correctly, it was reverted due to failing Lacros tests (Chrome OS-related).

Given the patch is a no-op unless the Vulkan CLI flag is passed, it'd be nice to have or some other way to test.

[emilylange]

I am not particularly sold on adding that patch.

It looks like it could be part of M127 (if the revert is reverted again).
And M127 is scheduled for 2024-07-23, so not too far away (~5 weeks).

So I would rather wait for M127 instead.

[tlvince]

No probs! I'll close this then.