Build failure: lv_img_conv

[rrix]

Steps To Reproduce

Steps to reproduce the behavior:

1. nix run nixpkgs#lv_img_conv w/ nixos-24.05 channel
2. or check hydra: https://hydra.nixos.org/build/260862301

Build log

lv_img_conv> npm ERR! In file included from ../../nan/nan.h:178,
lv_img_conv> npm ERR!                  from ../src/lmdb-js.h:32,
lv_img_conv> npm ERR!                  from ../src/lmdb-js.cpp:1:
lv_img_conv> npm ERR! ../../nan/nan_callbacks.h:55:23: error: 'AccessorSignature' is not a member of 'v8'
lv_img_conv> npm ERR!    55 | typedef v8::Local<v8::AccessorSignature> Sig;
lv_img_conv> npm ERR!       |                       ^~~~~~~~~~~~~~~~~
lv_img_conv> npm ERR! ../../nan/nan_callbacks.h:55:40: error: template argument 1 is invalid
lv_img_conv> npm ERR!    55 | typedef v8::Local<v8::AccessorSignature> Sig;
lv_img_conv> npm ERR!       |                                        ^
lv_img_conv> npm ERR! ../../nan/nan.h: In function 'void Nan::SetAccessor(v8::Local<v8::ObjectTemplate>, v8::Local<v8::String>, GetterCallback, SetterCallback, v8::Local<v8::Value>, v8::AccessControl, v8::PropertyAttribute, imp::Sig)':
lv_img_conv> npm ERR! ../../nan/nan.h:2544:19: error: no matching function for call to 'v8::ObjectTemplate::SetAccessor(v8::Local<v8::String>&, void (*&)(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>&), void (*&)(v8::Local<v8::Name>, v8::Local<v8::Value>, const v8::PropertyCallbackInfo<void>&), v8::Local<v8::Object>&, v8::AccessControl&, v8::PropertyAttribute&, Nan::imp::Sig&)'
lv_img_conv> npm ERR!  2544 |   tpl->SetAccessor(
lv_img_conv> npm ERR!       |   ~~~~~~~~~~~~~~~~^
lv_img_conv> npm ERR!  2545 |       name
lv_img_conv> npm ERR!       |       ~~~~
lv_img_conv> npm ERR!  2546 |     , getter_
lv_img_conv> npm ERR!       |     ~~~~~~~~~
lv_img_conv> npm ERR!  2547 |     , setter_
lv_img_conv> npm ERR!       |     ~~~~~~~~~
lv_img_conv> npm ERR!  2548 |     , obj
lv_img_conv> npm ERR!       |     ~~~~~
lv_img_conv> npm ERR!  2549 |     , settings
lv_img_conv> npm ERR!       |     ~~~~~~~~~~
lv_img_conv> npm ERR!  2550 |     , attribute
lv_img_conv> npm ERR!       |     ~~~~~~~~~~~
lv_img_conv> npm ERR!  2551 |     , signature);
lv_img_conv> npm ERR!       |     ~~~~~~~~~~~~
lv_img_conv> npm ERR! In file included from /nix/store/nxbymm4w70fpp56jn7wqyrjiyd0zlhq4-nodejs-20.12.2-source/deps/v8/include/v8-function.h:15,
lv_img_conv> npm ERR!                  from /nix/store/nxbymm4w70fpp56jn7wqyrjiyd0zlhq4-nodejs-20.12.2-source/deps/v8/include/v8.h:33,
lv_img_conv> npm ERR!                  from ../src/lmdb-js.h:29:
lv_img_conv> npm ERR! /nix/store/nxbymm4w70fpp56jn7wqyrjiyd0zlhq4-nodejs-20.12.2-source/deps/v8/include/v8-template.h:809:8: note: candidate: 'void v8::ObjectTemplate::SetAccessor(v8::Local<v8::String>, v8::AccessorGetterCallback, v8::AccessorSetterCallback, v8::Local<v8::Value>, v8::AccessControl, v8::PropertyAttribute, v8::SideEffectType, v8::SideEffectType)'
lv_img_conv> npm ERR!   809 |   void SetAccessor(
lv_img_conv> npm ERR!       |        ^~~~~~~~~~~
lv_img_conv> npm ERR! /nix/store/nxbymm4w70fpp56jn7wqyrjiyd0zlhq4-nodejs-20.12.2-source/deps/v8/include/v8-template.h:814:22: note:   no known conversion for argument 7 from 'Nan::imp::Sig' {aka 'int'} to 'v8::SideEffectType'
lv_img_conv> npm ERR!   814 |       SideEffectType getter_side_effect_type = SideEffectType::kHasSideEffect,
lv_img_conv> npm ERR!       |       ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lv_img_conv> npm ERR! /nix/store/nxbymm4w70fpp56jn7wqyrjiyd0zlhq4-nodejs-20.12.2-source/deps/v8/include/v8-template.h:816:8: note: candidate: 'void v8::ObjectTemplate::SetAccessor(v8::Local<v8::Name>, v8::AccessorNameGetterCallback, v8::AccessorNameSetterCallback, v8::Local<v8::Value>, v8::AccessControl, v8::PropertyAttribute, v8::SideEffectType, v8::SideEffectType)'
lv_img_conv> npm ERR!   816 |   void SetAccessor(
lv_img_conv> npm ERR!       |        ^~~~~~~~~~~
lv_img_conv> npm ERR! /nix/store/nxbymm4w70fpp56jn7wqyrjiyd0zlhq4-nodejs-20.12.2-source/deps/v8/include/v8-template.h:821:22: note:   no known conversion for argument 7 from 'Nan::imp::Sig' {aka 'int'} to 'v8::SideEffectType'
lv_img_conv> npm ERR!   821 |       SideEffectType getter_side_effect_type = SideEffectType::kHasSideEffect,
lv_img_conv> npm ERR!       |       ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lv_img_conv> npm ERR! make: *** [lmdb.target.mk:140: Release/obj.target/lmdb/src/lmdb-js.o] Error 1
lv_img_conv> npm ERR! gyp ERR! build error
lv_img_conv> npm ERR! gyp ERR! stack Error: `make` failed with exit code: 2

Additional context

Add any other context about the problem here.

Notify maintainers

@StarGate01 ping :)

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[rrix@virtuous-cassette:~/Code/InfiniTime]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.32, NixOS, 24.05 (Uakari), 24.05pre-git`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - nixpkgs: `/home/rrix/Code/nixpkgs`

---

[StarGate01]

Do you need this package? The original reason I added it was to support building https://github.com/InfiniTimeOrg/InfiniTime . Recently, that project has deprecated lv_img_conv and instead uses their own tooling (https://github.com/InfiniTimeOrg/InfiniTime/releases/tag/1.14.0 , "Replace the node.js tool that convert the images (lv_img_conv) by a custom re-implementation in Python"), so my use-case for this package has disappeared.

I don't know what is causing this issue, I tried rebuilding the package with the most recent changes from its repo, but no success. I propose to mark this package as broken or remove it.

[rrix]

fascinating, you're right. I was using it to build infinitime too and have that working now by adding pillow to my devShell's python environemnt.

might just want to mark it as broken and move along then. cheers