Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ifcopenshell build is broken #312380

Closed
autra opened this issue May 17, 2024 · 3 comments · Fixed by #312381
Closed

ifcopenshell build is broken #312380

autra opened this issue May 17, 2024 · 3 comments · Fixed by #312381

Comments

@autra
Copy link
Contributor

autra commented May 17, 2024

Describe the bug

The build of ifcopenshell is broken, see https://hydra.nixos.org/job/nixpkgs/trunk/ifcopenshell.aarch64-linux

Steps To Reproduce

Steps to reproduce the behavior:

  1. nix-env -iA ifcopenshell

fails.

The current error (but I have already fixed this one):

CMake Error at /build/source/src/svgfill/CMakeLists.txt:53 (message):
  Unable to find GMP library files, aborting

Expected behavior

The build is downloaded from cache.nixos.org OR it compiles successfully

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

Notify maintainers

@fehnomenal

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

- system: `"x86_64-linux"`
 - host os: `Linux 6.1.87, NixOS, 23.11 (Tapir), 23.11.20240424.dd37924`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a 👍 reaction to issues you find important.

@autra
Copy link
Contributor Author

autra commented May 17, 2024

(note: I've already made some progress, so I'm opening a draft MR right away)

@autra
Copy link
Contributor Author

autra commented May 17, 2024

To give a bit of context, I need ifc support in freecad and that needs ifcopenshell. I see that ifcopenshell is more or less considered as a python package (the derivation is wrapped in a buildPythonPackage. As I actually want the .so at the end, will this be a problem for me later?

But first, I need to fix the build. I've made progress, adding some missing deps:

  • libgmp
  • libmpfr
  • cgal (I need to check why I needed this one)

I might have a problem with the linker needing -libstdc++ flag, but I see this error only when the number of jobs is > 1. I'll see this later.

The error I'm currently facing with make -j1 is with libhdf5:

  • build with hdf5 disabled is currently broken upstream. I'm considering opening a PR with the suggested change and adding a patch in the build process for this
  • that being said, it'd be nice to be able to build it with hdf5 support! I'm currently working on this (more exactly, trying to work around ifcopenshell assumptions about lib structure)

At the end, what is the best practice considering build options? Should I create withFoo boolean args for the derivation? Or should we activate all that we can by default?

Thanks!

@autra
Copy link
Contributor Author

autra commented May 17, 2024

For reference: IfcOpenShell/IfcOpenShell#1759 (it's not the only issue about this hdf5 problem, just the one I found most relevant apart from the one above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants