Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic long Git hash version #4

Closed
szszszsz opened this issue Aug 12, 2020 · 5 comments
Closed

Automatic long Git hash version #4

szszszsz opened this issue Aug 12, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@szszszsz
Copy link
Member

For the development and CI/CD purposes it would be nice to have each build extended with a file containing the long commit hash, which could be easily checked in the recovery shell or perhaps written in the system info.
@szszszsz szszszsz added the enhancement New feature or request label Aug 12, 2020
@alex-nitrokey
Copy link

The git has is already stored as a variable in /tmp/config. I will use this for version info.

Furthermore, I want to adapt the Makefile to just append the hash to each build-file, so that they are unique and not all called coreboot.rom. Does this sound like a good solution to you?

@szszszsz
Copy link
Member Author

Ok!
Something like coreboot-<version>.rom? That would be nice.

@alex-nitrokey
Copy link

Done here.

@szszszsz
Copy link
Member Author

Looks good!

@alex-nitrokey
Copy link

Fixed in v1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szszszsz @alex-nitrokey